Repository navigation
fix(ios): Register replay mask classes when sample rates are 0 - #7008
Merged
Merged
Conversation
alwx
added a commit
that referenced
this pull request
Nov 10, 2026
Replace the PR number placeholder in the changelog entry with #7008.
Contributor
Semver Impact of This PR⚪ None (no version bump detected) 📋 Changelog PreviewThis is how your changes will appear in the changelog.
🤖 This preview updates automatically when you update the PR. |
alwx
marked this pull request as ready for review
November 10, 2026 10:46
alwx
requested review from
antonis and
buenaflor
and removed request for
a team
November 10, 2026 10:46
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
Want reviews to match your repository better? Bugbot Learning can learn team-specific rules from PR activity. A team admin can enable Learning in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit eda6aa0. Configure here.
📲 Install BuildsAndroid
|
RNSentryStart ran RNSentryReplay postInit only when a replay sample rate was above 0. Since 8.27 you can start a replay manually with both rates at 0, and sentry-cocoa always installs the replay integration. Such a replay recorded without the RN mask and unmask container classes and without the RN breadcrumb converter, so Sentry.Unmask and Sentry.Mask had no effect. postInit now runs whenever replay is supported. It starts no recording. It only configures the installed integration, and the cocoa calls do nothing when the integration is missing. A new OCMock test starts the SDK with both rates at 0 and checks that postInit runs. It fails with the old condition. Fixes #6996
Replace the PR number placeholder in the changelog entry with #7008.
alwx
force-pushed
the
alwx/bugfix/6996
branch
from
November 10, 2026 16:09
eda6aa0 to
64f3774
Compare
alwx
enabled auto-merge (squash)
November 10, 2026 16:10
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📢 Type of change
📜 Description
RNSentryStartnow calls[RNSentryReplay postInit]whenever session replay is supported, not only when a replay sample rate is above 0.postInitstarts no recording. It only registers theMaskandUnmaskcontainer classes and the RN breadcrumb converter on the installed replay integration.💡 Motivation and Context
Since 8.27 you can start a replay manually with both sample rates at 0, and sentry-cocoa always installs the replay integration. On iOS such a replay had no RN container classes, so
Sentry.UnmaskandSentry.Maskhad no effect. Fixes #6996.💚 How did you test it?
A new OCMock test starts the SDK with both rates at 0 and checks that
postInitruns. It fails with the old condition and passes with the fix. The full RNSentryCocoaTester suite passes on an iOS simulator (208 tests).📝 Checklist
sendDefaultPIIis enabled.