Skip to content

C++: Small cleanup on FlowSummaryImpl.qll #23118

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
MathiasVP merged 1 commit into from
Nov 13, 2026
Merged

C++: Small cleanup on FlowSummaryImpl.qll #23118

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 6 additions & 6 deletions cpp/ql/lib/semmle/code/cpp/dataflow/internal/FlowSummaryImpl.qll
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -275,12 +275,12 @@ private module Input2 implements Impl::Private::InputSig2 {
exists(DataFlowCall call |
exists(ArgumentPosition pos |
sc = Impl::Private::SummaryComponent::argument(pos) and
pos.getArgument(call.asCallInstruction().getUnconvertedResultExpression()) = e
|
pos.getIndirectionIndex() = 0 and
result.(PostUpdateNode).getPreUpdateNode().asExpr() = e
or
result.(PostUpdateNode).getPreUpdateNode().asIndirectExpr(pos.getIndirectionIndex()) = e
pos.getArgument(call.asCallInstruction().getUnconvertedResultExpression()) = e and
result
.(PostUpdateNode)
.getPreUpdateNode()
.(ArgumentNode)
.sourceArgumentOf(call.asCallInstruction(), pos)
Comment on lines -278 to +283

@jketema jketema Nov 12, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think I need some explanation as to why this works just as well.

@MathiasVP MathiasVP Nov 12, 2026

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We had the logic of sourceArgumentOf duplicated in FlowSummaryImpl. If the indirection index was 0 we picked the asExpr node, and otherwise we used the indirection index to get the indirect node. The same logic is implemented in the sourceArgumentOf predicate (where PrimaryArgumentNode implements the direct case, and SideEffectArgumentNode represents the indirect case).

)
or
exists(ReturnKind rk |
Expand Down
Loading