Skip to content

Rust: Prevent MaD suppression for heuristic call-back summary #23126

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
hvitved wants to merge 2 commits into
base: main
Choose a base branch
from
Draft

Rust: Prevent MaD suppression for heuristic call-back summary #23126

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
deefa80
Rust: More data flow tests
hvitved Nov 13, 2026
7792dd0
Rust: Prevent MaD suppression for heuristic call-back summary
hvitved Nov 13, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
32 changes: 24 additions & 8 deletions rust/ql/lib/codeql/rust/dataflow/internal/ModelsAsData.qll
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -194,6 +194,16 @@ predicate interpretPath(string path, Function f, Provenance orig, Provenance p,
)
}

private predicate summaryModel(
Function f, string input, string output, string kind, Provenance p, boolean isExact,
QlBuiltins::ExtensionId madId
) {
exists(string path, Provenance p_ |
summaryModel(path, input, output, kind, p_, madId) and
interpretPath(path, f, p_, p, isExact)
)
}

private class SummarizedCallableFromModel extends SummarizedCallable::Range {
string input_;
string output_;
Expand All @@ -202,12 +212,7 @@ private class SummarizedCallableFromModel extends SummarizedCallable::Range {
boolean isExact_;
QlBuiltins::ExtensionId madId;

SummarizedCallableFromModel() {
exists(string path, Provenance p |
summaryModel(path, input_, output_, kind, p, madId) and
interpretPath(path, this, p, p_, isExact_)
)
}
SummarizedCallableFromModel() { summaryModel(this, input_, output_, kind, p_, isExact_, madId) }

override predicate propagatesFlow(
string input, string output, boolean preservesValue, Provenance p, boolean isExact, string model
Expand Down Expand Up @@ -237,6 +242,10 @@ predicate mayInvokeCallback(Function f, int n) {
)
}

private predicate hasGeneratedSummaryModel(Function f, boolean isExact) {
summaryModel(f, _, _, _, any(Provenance g | g.isGenerated()), isExact, _)
}

private class SummarizedCallableWithCallback extends SummarizedCallable::Range {
private int pos;

Expand All @@ -249,8 +258,15 @@ private class SummarizedCallableWithCallback extends SummarizedCallable::Range {
output = "Argument[" + pos + "].Parameter[closure-self]" and
preservesValue = true and
p = "hq-generated" and
isExact = true and
model = "heuristic-callback"
model = "heuristic-callback" and
// If a generated model already exists for this function, inherit its exactness
// to prevent that either model suppresses the other
(
hasGeneratedSummaryModel(this, isExact)
or
not hasGeneratedSummaryModel(this, _) and
isExact = true
)
}
}

Expand Down
Loading
Loading