Repository navigation
Conversation
Record exact call targets and end-to-end value flow before the DataFlowIntegration migration. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Record pre-integration behavior for captured overwrites, loop-carried interface values, typed nil pointers, and unknown origins. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
We do not use closure flow or barrier guards.
Keep synthetic read and phi nodes in the analysis while omitting them from path explanations. Add regression coverage for state-changing steps and neverSkip configurations. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Propagate unknown origins instead of recursively proving every predecessor concrete. Treat uncertain writes conservatively and require a concrete origin, allowing known types to pass through SSA cycles. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Track possibly nil origins instead of recursively proving every predecessor non-nil. Treat captured writes conservatively and handle loop-carried values while retaining typed-nil and post-update semantics. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
owen-mc
force-pushed
the
go/data-flow-integration
branch
from
November 13, 2026 16:49
f3daf4e to
135d102
Compare
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Use the shared DataFlowIntegration library for Go’s local SSA flow, following the earlier migration to MakeSsa.
The change preserves Go’s existing field-sensitive barrier guards and closure-flow modelling.
The shared graph retains merge nodes and cycles that were previously flattened. Adapt interface dispatch and the impossible-interface-nil-check query to handle these without changing their intended behavior. Hide internal merge nodes from path explanations.
Also enable SSA consistency checks and fix spurious reads of select-receive assignment targets. Remaining single-input phi findings arise because Go adds synthetic uncertain reads at function exits to retain captured definitions. Those reads extend liveness onto paths where no local definition exists.