Repository navigation
Conversation
nickrolfe
changed the title
nickrolfe
force-pushed
the
nickrolfe/model-editor-json-default
branch
from
October 8, 2026 14:07
5762442 to
96fcad5
Compare
nickrolfe
force-pushed
the
nickrolfe/model-editor-json-default
branch
from
November 12, 2026 15:55
96fcad5 to
5bad6be
Compare
nickrolfe
marked this pull request as ready for review
November 12, 2026 15:58
Contributor
There was a problem hiding this comment.
🟡 Changes recommended
Existing model-pack manifests may still match only YAML files, causing newly saved JSON models to be ignored by the CLI and omitted on reload and from analysis.
1 open issue
What changed in this PR
Switches the model editor’s default format for new data extension files to JSON, building on the existing JSON loading and format-preserving save support.
Changes:
- Sets JSON as the default for newly created model files.
- Extends CLI integration tests to discover and load both JSON and YAML models.
- Documents the default-format change in the changelog.
| File | Description |
|---|---|
extensions/ql-vscode/test/vscode-tests/cli-integration/model-editor/modeled-method-fs.test.ts |
Adds JSON fixtures and mixed-format discovery and loading coverage. |
extensions/ql-vscode/src/model-editor/modeled-method-fs.ts |
Changes the new-file default from YAML to JSON. |
extensions/ql-vscode/CHANGELOG.md |
Announces the JSON default for new data extensions. |
Review effort: Balanced (auto)
| import type { QueryLanguage } from "../common/query-language"; | ||
|
|
||
| export const DEFAULT_EXTENSION_FORMAT_FOR_NEW_FILES = ExtensionFormat.Yaml; | ||
| export const DEFAULT_EXTENSION_FORMAT_FOR_NEW_FILES = ExtensionFormat.Json; |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stacked on top of #4576. This one is blocked on CLI support for JSON data extensions being released.
As well as switching to JSON as the default, it also updates a CLI integration test to cover JSON.