Repository navigation
consume the kit's icons: delete three local files, bump v0.14.0 → v0.17.0 - #34
Merged
Merged
Conversation
…17.0 This repository carried exactly three files under `layouts/partials/` beyond what the kit provides, and all three were duplication: ``` layouts/partials/icons/graph.html Octicons "graph", verbatim layouts/partials/icons/rocket.html Octicons "rocket", verbatim layouts/partials/icons/OCTICONS-LICENSE byte-identical to the kit's ``` They were **additions, not overrides** — nothing was being shadowed — but they were not local in any meaningful sense: both icons come from the same Octicons release the kit's own name (`@primer/octicons-react@19.40.0`), carry the same `currentColor`/`aria-hidden` convention as `icons/github.html`, and contain nothing specific to this project. A graph and a rocket are what any landing's benchmarks and quickstart buttons want. go-fleettools/landingkit#27 moved them into the kit (v0.17.0). This consumes them. ## Proven by the only test that settles it: the built site is byte-identical ```console $ hugo --destination …/baseline # on main, with the local copies $ # delete the three files, bump the kit $ hugo --destination …/after $ diff -r …/baseline …/after $ echo $? 0 ``` **Zero lines of difference.** The icons now resolve from the module and render the same bytes, and three minor versions of kit changes (v0.14.0 → v0.17.0, a bump that was overdue on its own) introduce no visible change to this site either. If a partial had gone missing, hugo would have failed rather than rendered nothing — so this also proves the kit really supplies them. `landingkit links` on the rebuilt site: every URL 200. ## Why copies were the problem rather than the files Every landing that wants a rocket copies one, and from then on there are N rockets: the next accessibility or sizing fix to `icons/github.html` reaches the kit's five and none of the copies. This kit exists because hand-copied `styles.html` and `theme-toggle.html` had already drifted between landings — `hugo.toml` says so at the `[module]` block. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
The commit before this one deletes the three local icon files and says it bumps
the kit. It did not: `go.mod` and `go.sum` were modified in the working tree and
**never staged**, so that commit alone deletes `icons/graph.html` and
`icons/rocket.html` while still pinning landingkit v0.14.0, which does not
provide them — hugo would fail on a missing partial.
This commit carries the bump (v0.14.0 → v0.17.0). The two belong together and
are only separate because amending a pushed commit rewrites history, which is
not worth it for a branch whose pull request is still to open.
## ⛔ Why I did not notice before pushing
The staging step was written as
git add -A go.mod go.sum layouts/partials > /dev/null 2>&1
Two mistakes in one line. `-A` with several pathspecs did not stage the two
module files here — plain `git add go.mod go.sum` does — and the output **and
exit status went to /dev/null**, so a step that half-failed looked exactly like
one that worked. The commit's own summary said "3 files changed", which is the
number that gave it away on a second reading.
The measurement in the previous commit's message is still true and was taken
with both changes present in the working tree: `diff -r` over the two builds is
byte-identical. It is this repository's recorded history that was wrong for one
commit, not the result.
Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
consume the kit's icons: delete three local files, bump v0.14.0 → v0.17.0
This repository carried exactly three files under
layouts/partials/beyondwhat the kit provides, and all three were duplication:
They were additions, not overrides — nothing was being shadowed — but they
were not local in any meaningful sense: both icons come from the same Octicons
release the kit's own name (
@primer/octicons-react@19.40.0), carry the samecurrentColor/aria-hiddenconvention asicons/github.html, and containnothing specific to this project. A graph and a rocket are what any landing's
benchmarks and quickstart buttons want.
go-fleettools/landingkit#27 moved them into the kit (v0.17.0). This consumes
them.
Proven by the only test that settles it: the built site is byte-identical
Zero lines of difference. The icons now resolve from the module and render
the same bytes, and three minor versions of kit changes (v0.14.0 → v0.17.0, a
bump that was overdue on its own) introduce no visible change to this site
either. If a partial had gone missing, hugo would have failed rather than
rendered nothing — so this also proves the kit really supplies them.
landingkit linkson the rebuilt site: every URL 200.Why copies were the problem rather than the files
Every landing that wants a rocket copies one, and from then on there are N
rockets: the next accessibility or sizing fix to
icons/github.htmlreaches thekit's five and none of the copies. This kit exists because hand-copied
styles.htmlandtheme-toggle.htmlhad already drifted between landings —hugo.tomlsays so at the[module]block.Co-Authored-By: Claude Opus 5 noreply@anthropic.com
Re-verified against main as it stands now (#33 merged)
The measurement above was taken before #33. Repeated with
mainmerged in, so the comparison is against what this PR would actually land on:Byte-identical, zero lines. And the version check that #33 turned on still passes here:
mainwas brought in by a merge rather than a rebase: rewriting a pushed branch needs a force-push, and nothing here is worth that.🤖 Generated with Claude Code