Repository navigation
Reject NaN values in bounded array validation - #25
Open
DiadkoShmek wants to merge 1 commit into
Open
DiadkoShmek wants to merge 1 commit into
DiadkoShmek wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A
NaNdiscount currently passesBoundedArray((), float, 0, 1).validate()and consequently passesEnvironmentTestMixinchecks, even though it does not belong to the declared interval.Validate that every value satisfies both inclusive bounds. This rejects unordered NaNs while retaining the existing endpoint, infinity and empty-array behavior. Add scalar/vector/broadcast-bound regressions and a NaN-discount environment sequence.
Validation: the new regressions fail on base
91b46797fea731f80eab8cd2c8352a0674141d89(7 failures). The full dm_env suite passes (168 tests, 6 subtests), plus 1,200 independently checked scalar interval cases across float16/32/64.CPU validation used Python 3.13 and NumPy 2.2.6; other version combinations were not tested. This keeps plain
Arrayvalidation unchanged, including its permitted NaN values.