Repository navigation
Conversation
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
10kartik
force-pushed
the
add-migration-repositories
branch
from
November 7, 2026 05:01
de9fb34 to
d68695f
Compare
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #4705 +/- ##
==========================================
- Coverage 98.64% 98.64% -0.01%
==========================================
Files 204 204
Lines 19080 19134 +54
==========================================
+ Hits 18822 18875 +53
- Misses 258 259 +1 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
| // GitHub API docs: https://docs.github.com/rest/migrations/orgs?apiVersion=2022-11-28#list-repositories-in-an-organization-migration | ||
| // | ||
| //meta:operation GET /orgs/{org}/migrations/{migration_id}/repositories | ||
| func (s *MigrationService) ListMigrationRepositories(ctx context.Context, org string, id int64, opts *ListOptions) ([]*Repository, *Response, error) { |
Contributor
There was a problem hiding this comment.
Suggested change
| func (s *MigrationService) ListMigrationRepositories(ctx context.Context, org string, id int64, opts *ListOptions) ([]*Repository, *Response, error) { | |
| func (s *MigrationService) ListRepositories(ctx context.Context, org string, migrationID int64, opts *ListOptions) ([]*Repository, *Response, error) { |
| t.Errorf("ListUserMigrationRepositories = %+v, want %+v", got, want) | ||
| } | ||
|
|
||
| const methodName = "ListUserMigrationRepositories" |
Contributor
There was a problem hiding this comment.
Use testBadOptions to increase test coverage.
| // GitHub API docs: https://docs.github.com/rest/migrations/users?apiVersion=2022-11-28#list-repositories-for-a-user-migration | ||
| // | ||
| //meta:operation GET /user/migrations/{migration_id}/repositories | ||
| func (s *MigrationService) ListUserMigrationRepositories(ctx context.Context, id int64, opts *ListOptions) ([]*Repository, *Response, error) { |
Contributor
There was a problem hiding this comment.
Suggested change
| func (s *MigrationService) ListUserMigrationRepositories(ctx context.Context, id int64, opts *ListOptions) ([]*Repository, *Response, error) { | |
| func (s *MigrationService) ListUserRepositories(ctx context.Context, migrationID int64, opts *ListOptions) ([]*Repository, *Response, error) { |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds two missing migration endpoints to
MigrationService:ListMigrationRepositories-GET /orgs/{org}/migrations/{migration_id}/repositoriesListUserMigrationRepositories-GET /user/migrations/{migration_id}/repositoriesBoth return
[]*Repositoryand takeListOptions. TheItermethods come fromgo generate.I used Claude Code to help write this and reviewed every line myself.
🤖 Generated with Claude Code