Repository navigation
Commit the agent rules and the verify-tools skill - #943
Merged
Merged
Conversation
The probe runs from each checkout's own copy, hashes with sha256sum and leaves Maven JVM flags to the machine.
CLAUDE.md imports it, so Claude Code, Cursor and Codex read the same rules in every clone and worktree.
probe.sh install ran mvn install without clean, so a class left in target/ by an earlier build could end up in the jar the probe tests. A missing or unknown scenario exited 1, which the skill documents as a harness failure. The hash falls back to shasum -a 256 where sha256sum is missing. The skill's run block now lists install. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
The layout said one test class per feature or issue, while the judgment rule says to add a variant to the existing class. The f8c7be7 example now says what that commit did: five failure tests folded into one, two dropped. The rule table header no longer claims every row names a failing check or an agent mistake. The jar row names module-info and java.version, the layout lists proxy/, the build command cleans, and a row covers stale classes in target/. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
Agents working in graphql-java-tools keep repeating the same mistakes, and the repo should change so a change that looks right from one file is right for the whole repo. First step is giving every clone the same rules. Right now the agent rules and the
verify-toolsskill only exist untracked in one checkout, so a fresh clone, a worktree started from master or a cloud agent gets neither. The rules there also still say Java 11 while the pom says 17.Checklist
Description
AGENTS.mdholds the project rules (layout, build, compatibility, GitHub, releases), five rules that need judgment with one real failure each, and a rule table. Each row is a rule from a mistake made here more than once, with what enforces it today. Most say "docs only" for now.CLAUDE.mdis just@AGENTS.md, so Claude Code, Cursor and Codex read the same file..claude/skills/verify-toolsis committed.probe.shruns from each checkout's own copy and no longer adds the macOS keychain trust store flag. Put JVM flags your machine needs in.mvn/jvm.configor~/.mavenrc.probe.sh installnow runsmvn clean install, so a class left intarget/by an earlier build can't end up in the jar the probe tests. That's also a new row in the rule table.probe.shexits 64 for a missing or unknown scenario, as the skill says, and usessha256sumor falls back toshasum -a 256on Macs without it..gitignoreignores.mvn/jvm.config,.local/,CLAUDE.local.md,.claude/settings.local.jsonand.claude/worktrees/.Scope
CLAUDE.local.md.verify-toolsskill is committed here.Blast Radius
Nobody using the library notices. A checkout with an untracked
CLAUDE.mdhas to move it out of the way before pulling, or git refuses to overwrite it.probe.sh installnow empties the checkout'starget/, so don't run it next to another build in the same checkout.Verification
mvn -B -ntp clean verifyon JDK 17: 440 tests, build passes.probe.sh installwith a fake class planted intarget/classes: the log showscleandeletingtarget/and the installed jar doesn't have the fake class.probe.sh runforread-only-schemaandasyncexits 0 witherrors=0.run no-such-scenarioandrunwith no scenario exit 64.doctorwithsha256sumoff thePATHgets the same work dir as with it.