[oryan-block]

Why

Agents working in graphql-java-tools keep repeating the same mistakes, and the repo should change so a change that looks right from one file is right for the whole repo. Two of those mistakes hide in the test setup. A test class that isn't named *Test never runs and the build still passes. And most of our assertions are Kotlin assert(), including assertEquals in TestUtils, which does nothing when the JVM runs without -ea.

Description

• surefire now includes every class and fails when no tests run. A class named FooTests or FooSpec runs, and an include that matches nothing fails with No tests were executed! instead of passing with zero tests. No helper or fixture class gets picked up, it's still 440 tests in 46 classes
• failIfNoTests is set as a property instead of in the plugin config, so the -DfailIfNoTests=false that surefire's error message suggests still turns the check off
• the Kotlin test compile gets -Xassertions=always-enable, so assert() in the tests runs whatever the runner does with -ea. Test compile only, so the published jar is unchanged
• removed the surefire-junit4 pin. Its comment said TestNG from reactive-streams-tck makes surefire run none of the JUnit 4 tests, which doesn't happen anymore. Surefire 3.6 runs JUnit 4 on the JUnit Platform and stopped publishing surefire-junit4 after 3.5.6, so the pin kept a 3.5.6 provider inside the 3.6.1 plugin. Without it all 440 still run, and failIfNoTests covers the case the pin was there for

Surefire and IntelliJ both pass -ea by default, so the assert part is cheap insurance more than a fix for something we hit. I didn't move TestUtils onto JUnit's Assert, since about 100 bare assert() calls in the tests would still need the flag.

No release note, nothing changes for library users.

Checklist

• Pull requests follows the contribution guide
• New or modified functionality is covered by tests

No new tests since it's build config. Each check was run against the mistake it's for, with mvn -B -ntp clean verify on JDK 25:

• a ProbeMisnamedTests class with a failing test passes on agent-friendly (440 tests) and fails here (Tests run: 441, Failures: 1)
• with the include changed to **/*Tests.*, agent-friendly passes with no tests run, this branch fails with No tests were executed!
• a broken assertEquals and a broken bare assert in DeprecatedDirectiveTest, run with -DenableAssertions=false, both pass without the flag and both fail with it

mvn clean verify passes on JDK 17 and 25 with 440 tests, same as agent-friendly. Build time didn't move noticeably (~11s, single runs).

[sonarqubecloud]

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud