Repository navigation
Fix zh-TW emoji picker showing Simplified Chinese labels - #265
Merged
Merged
Conversation
Codex Review Summary: ✅ CompletedThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
In v3.4.0, the emoji picker showed Simplified Chinese (
zh-CN) labels for visitors whose locale iszh-TW, because the locale map pointedzh-TWat the same emoji-mart translation object aszh-CN.@emoji-mart/datadoes not ship a Traditional Chinese translation (onlyzh.json), sozh-TWneeds its own locale object.Fixes #261.
Changes
zhTW) and mapzh-TWto it inemoji-button.ts.language=zh-TWand asserts the search placeholder and category labels are Traditional Chinese.Reproduction
languagecookie) tozh-TW.搜索and表情与角色.Verification
After the fix, the same steps show
搜尋and表情與角色.pnpm test— 35 files / 186 tests passedpnpm build— passedzh-TWmapping and passes with the fix.