Skip to content

Check SDK Docker scripts on Bash 3.2 - #590

Merged
jspaetzel merged 1 commit into
fix/sdk-docker-file-ownershipfrom
fix/sdk-docker-bash32
Nov 4, 2026
Merged

jspaetzel merged 1 commit into
fix/sdk-docker-file-ownershipfrom
fix/sdk-docker-bash32

Conversation

@jspaetzel

Copy link
Copy Markdown
Member

Summary

  • Keeps the SDK Docker wrappers runnable on Bash 3.2, which is the Bash macOS ships. mapfile is replaced with a read loop, and bin/php-in-docker no longer expands an empty array under set -u.
  • Adds a GitHub Actions check that runs those scripts under the bash:3.2 image when they change. bash -n alone misses mapfile, so the check also rejects Bash 4 syntax and executes the wrappers with docker stubbed.
  • Stacked on Run SDK Docker builds as the host user #575. Retarget this to main after that pull request merges.

Test plan

  • ./bin/check-bash32 passes under Bash 3.2.57
  • Adding mapfile to bin/docker-run fails the check
  • Expanding an empty array from bin/php-in-docker fails the check
  • Confirm the new workflow runs on this pull request

Made with Cursor

macOS ships Bash 3.2, which rejects mapfile and empty arrays under set -u. Run that check when the wrappers change.

Co-authored-by: Cursor <cursoragent@cursor.com>
@jspaetzel
jspaetzel merged commit 23bfd20 into fix/sdk-docker-file-ownership Nov 4, 2026
1 check passed
@jspaetzel
jspaetzel deleted the fix/sdk-docker-bash32 branch November 4, 2026 20:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant