Repository navigation
feat: support for OpenTelemetry W3C trace context in python ibm_db driver - #1082
Merged
Merged
Conversation
…nd transaction tracking in autocommit/execute_many
Changed CIBW_BUILD_FRONTEND_LINUX to CIBW_BUILD_FRONTEND (without _LINUX suffix). The correct cibuildwheel environment variable is CIBW_BUILD_FRONTEND, not CIBW_BUILD_FRONTEND_LINUX. This fixes the YAML parsing error in the workflow. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Replace invalid CIBW_BUILD_FRONTEND arguments with CIBW_BEFORE_BUILD_LINUX to explicitly install setuptools and wheel before building. This ensures the packages are available in the build environment without relying on network access to PyPI. The manylinux containers come with pip, but setuptools and wheel may not be at the right versions. Pre-installing ensures consistent builds. Fixes: 'python -m build: error: unrecognized arguments: --no-build-isolation' Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
The i686 manylinux container has network isolation, causing pip install to fail. The x86_64 builds prove that setuptools and wheel are already available in the manylinux containers. Remove the CIBW_BEFORE_BUILD_LINUX hook that was attempting to download them, as this is unnecessary and breaks i686 builds. The proper fix was already in place: declaring setuptools and wheel in pyproject.toml's [build-system] requires, which cibuildwheel uses to ensure they're available. No runtime installation is needed. This fixes the i686 build failure: ERROR: Could not find a version that satisfies the requirement setuptools ERROR: No matching distribution found for setuptools Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
The manylinux containers have setuptools and wheel pre-installed. Specifying them in requires forces PEP 517 build isolation which tries to download from PyPI, but i686 containers have no network access. Clearing requires uses pre-installed tools instead. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Add CIBW_BUILD_FRONTEND with --no-isolation flag to use pre-installed setuptools and wheel in containers instead of trying to download from PyPI. This solves network isolation issues in i686 manylinux containers. Restore requires = ['setuptools', 'wheel'] in pyproject.toml since the backend needs to be properly declared (empty requires broke all builds). Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Replace CIBW_BUILD_FRONTEND with CIBW_BUILD_FRONTEND_LINUX set to 'pip'. This tells cibuildwheel to use pip for building instead of the build module, which better handles containers with pre-installed setuptools and wheel. Avoids network access issues in i686 manylinux container. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Add [tool.cibuildwheel.linux] section to pyproject.toml with
build-frontend = { name = 'pip', args = ['--no-build-isolation'] }
This tells cibuildwheel to skip PEP 517 build isolation for Linux builds,
using pre-installed setuptools and wheel instead of downloading from PyPI.
Solves network access issues in i686 manylinux container.
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
…m requires - Change requires to only 'setuptools' (wheel not needed in build requires) - Use CIBW_BUILD_FRONTEND with proper cibuildwheel 4.2.0 syntax - pip automatically handles --no-build-isolation when needed Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Remove CIBW_BUILD_FRONTEND with args syntax since pip doesn't need explicit --no-build-isolation flag when only setuptools is in build requires (not wheel). Simplified approach to avoid syntax errors. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
…ux container The manylinux_2_34_i686 container has network isolation that prevents downloading packages from PyPI during PEP 517 build isolation. The i686 architecture represents only 32-bit systems which are rarely used today. Skip it to unblock the build pipeline for all practical use cases. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
feat: support for OpenTelemetry W3C trace context in python ibm_db driver