Skip to content

fix(ecr): retain main builds with the correct tag prefix #190

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Alexanderamiri merged 1 commit into from
Nov 10, 2026
Merged

fix(ecr): retain main builds with the correct tag prefix #190

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion docs/reusable-modules.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,7 @@ ECR repository with 4-rule lifecycle policy.
| Rule | Default |
|------|---------|
| Keep N semver releases (`v*`) | 5 |
| Keep N main builds (`main-*`, `master-*`) | 3 |
| Keep N main builds (`main-*`) | 3 |
| Expire untagged | 1 day |
| Expire other tags | 7 days |

Expand Down
2 changes: 1 addition & 1 deletion terraform/modules/ecr-repo/main.tf
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -40,7 +40,7 @@ resource "aws_ecr_lifecycle_policy" "this" {
description = "Keep last ${var.main_keep_count} main builds"
selection = {
tagStatus = "tagged"
tagPrefixList = ["main-", "master-"]
tagPrefixList = ["main-"]
countType = "imageCountMoreThan"
countNumber = var.main_keep_count
}
Expand Down
2 changes: 1 addition & 1 deletion terraform/modules/ecr-repo/variables.tf
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,7 @@ variable "semver_keep_count" {
}

variable "main_keep_count" {
description = "Number of main/master branch build images to keep"
description = "Number of main branch build images to keep"
type = number
default = 3
}
Expand Down
Loading