Skip to content

fix(settings): the Google disconnect dialog no longer says imported reviews are removed - #1080

Open
kodes-agency wants to merge 2 commits into
mainfrom
fix/google-disconnect-dialog-copy
Open

kodes-agency wants to merge 2 commits into
mainfrom
fix/google-disconnect-dialog-copy

Conversation

@kodes-agency

Copy link
Copy Markdown
Owner

What changed

The confirmation for disconnecting a Google account said RepKey "removes the reviews and replies it imported". It does not: disconnecting stops syncing and replying through the account and revokes its access, and the imported reviews and replies stay in the Inbox until Google's 30-day limit. The dialog now says that:

RepKey stops syncing and replying through this account for every property that uses it, and revokes its access. Reviews and replies it imported stay in the Inbox until Google's 30-day limit. Nothing is deleted on Google.

The comment above the dialog and the story's header comment made the same claim and are corrected. No other text changes. Nothing else in the repository (tests, stories, docs) repeats the old sentence.

How it was tested

  • The new description matches the intended sentence character for character.
  • The Storybook stories for the row (asks before disconnecting, keep connected, light theme) pass.
  • Unit and source-scan tests for components/features/settings, components/features/integration/connect-google-button and components/ui pass (78 files, 821 tests).
  • ESLint, Prettier and pnpm typecheck pass.

🤖 Generated with Claude Code

…eviews are removed

Disconnecting a Google account stops syncing and replying and revokes access, but the reviews and replies it imported stay in the Inbox until Google's 30-day limit. The confirmation said they are removed. It now says what happens, and the comments above it say the same.

Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
@ecc-tools

ecc-tools Bot commented Nov 4, 2026

Copy link
Copy Markdown

ECC Tools / Security Evidence

Commit: f0e28c06cf29fbe445c5fe1b930d70d299fc90af

Security evidence gate passed (success)

No security-sensitive scanner-evidence gap detected.

Mode: enforce

Scanned 2 changed file(s). No missing scanner-evidence signal was detected.

Check publication was denied or unavailable. An app owner must enable Checks: read and write, and the installation owner must approve the updated permission.

@ecc-tools

ecc-tools Bot commented Nov 4, 2026

Copy link
Copy Markdown

ECC Tools / PR Risk Taxonomy

Commit: f0e28c06cf29fbe445c5fe1b930d70d299fc90af

PR taxonomy review recommended (neutral)

Detected 1 PR taxonomy bucket(s): CI/CD Recommendation.

Scanned 2 changed file(s).

Roadmap taxonomy buckets:

CI/CD Recommendation

CI, dependency, coverage, and contract signals should be routed into follow-up checks or verification work.

Signals:

  • User-facing UI changes may ship without browser coverage
  • 0 CI or workflow path(s) changed

Paths:

  • src/components/features/settings/google-connection-settings-row.stories.tsx
  • src/components/features/settings/google-connection-settings-row.tsx

Check publication was denied or unavailable. An app owner must enable Checks: read and write, and the installation owner must approve the updated permission.

@kodes-agency
kodes-agency enabled auto-merge (squash) November 4, 2026 20:40
@ecc-tools

ecc-tools Bot commented Nov 4, 2026

Copy link
Copy Markdown

ECC Tools / Reference Set Readiness

Commit: f0e28c06cf29fbe445c5fe1b930d70d299fc90af

Reference set readiness gaps detected (neutral)

Reference evidence present for 0/7 areas (0%) across 2 changed file(s).

This check is based on files changed in this PR. Repository-level readiness is still reported by /ecc-tools analyze comments and generated manifests.

Area Status Evidence / Next Step
Deep analyzer corpus Missing Add analyzer fixture, golden, benchmark, or reference-set files that can catch analyzer regressions.
RAG/evaluator comparison Missing Add retrieval or evaluator reference-set comparison fixtures with expected ranking behavior.
PR salvage/review corpus Missing Add stale-PR, review-thread, reopen-flow, or salvage reference cases for queue cleanup automation.
Discussion triage corpus Missing Add public discussion triage fixtures, golden cases, or reference sets for informational, answered, and no-response classifications.
Harness compatibility Missing Add cross-harness, adapter-compliance, or harness-audit evidence for Claude, Codex, OpenCode, Zed, dmux, and agent surfaces.
Security evidence Missing Attach security evidence such as SBOMs, SARIF, audit reports, or AgentShield evidence packs.
CI failure-mode evidence Missing Add captured CI failure logs, dry-run fixtures, or troubleshooting docs for common workflow failure modes.

Check publication was denied or unavailable. An app owner must enable Checks: read and write, and the installation owner must approve the updated permission.

@ecc-tools

ecc-tools Bot commented Nov 4, 2026

Copy link
Copy Markdown

ECC Tools / Hosted Promotion Readiness

Commit: f0e28c06cf29fbe445c5fe1b930d70d299fc90af

Hosted promotion readiness passed (success)

No hosted promotion evidence gaps detected across 2 changed file(s); 0 corpus scenarios had matching evidence.

This check compares PR file changes against the evaluator/RAG promotion corpus in src/analyzers/fixtures/evaluator-rag-corpus.ts.
Hosted output scoring inspected 0 completed cached hosted job results.

No evaluator corpus scenarios matched this PR.

Check publication was denied or unavailable. An app owner must enable Checks: read and write, and the installation owner must approve the updated permission.

@ecc-tools

ecc-tools Bot commented Nov 4, 2026

Copy link
Copy Markdown

ECC Tools / Security Evidence

Commit: 00b8ae2e525274a97cc9000dff2d81421caca173

Security evidence gate passed (success)

No security-sensitive scanner-evidence gap detected.

Mode: enforce

Scanned 2 changed file(s). No missing scanner-evidence signal was detected.

Check publication was denied or unavailable. An app owner must enable Checks: read and write, and the installation owner must approve the updated permission.

@ecc-tools

ecc-tools Bot commented Nov 4, 2026

Copy link
Copy Markdown

ECC Tools / PR Risk Taxonomy

Commit: 00b8ae2e525274a97cc9000dff2d81421caca173

PR taxonomy review recommended (neutral)

Detected 1 PR taxonomy bucket(s): CI/CD Recommendation.

Scanned 2 changed file(s).

Roadmap taxonomy buckets:

CI/CD Recommendation

CI, dependency, coverage, and contract signals should be routed into follow-up checks or verification work.

Signals:

  • User-facing UI changes may ship without browser coverage
  • 0 CI or workflow path(s) changed

Paths:

  • src/components/features/settings/google-connection-settings-row.stories.tsx
  • src/components/features/settings/google-connection-settings-row.tsx

Check publication was denied or unavailable. An app owner must enable Checks: read and write, and the installation owner must approve the updated permission.

@ecc-tools

ecc-tools Bot commented Nov 4, 2026

Copy link
Copy Markdown

ECC Tools / Reference Set Readiness

Commit: 00b8ae2e525274a97cc9000dff2d81421caca173

Reference set readiness gaps detected (neutral)

Reference evidence present for 0/7 areas (0%) across 2 changed file(s).

This check is based on files changed in this PR. Repository-level readiness is still reported by /ecc-tools analyze comments and generated manifests.

Area Status Evidence / Next Step
Deep analyzer corpus Missing Add analyzer fixture, golden, benchmark, or reference-set files that can catch analyzer regressions.
RAG/evaluator comparison Missing Add retrieval or evaluator reference-set comparison fixtures with expected ranking behavior.
PR salvage/review corpus Missing Add stale-PR, review-thread, reopen-flow, or salvage reference cases for queue cleanup automation.
Discussion triage corpus Missing Add public discussion triage fixtures, golden cases, or reference sets for informational, answered, and no-response classifications.
Harness compatibility Missing Add cross-harness, adapter-compliance, or harness-audit evidence for Claude, Codex, OpenCode, Zed, dmux, and agent surfaces.
Security evidence Missing Attach security evidence such as SBOMs, SARIF, audit reports, or AgentShield evidence packs.
CI failure-mode evidence Missing Add captured CI failure logs, dry-run fixtures, or troubleshooting docs for common workflow failure modes.

Check publication was denied or unavailable. An app owner must enable Checks: read and write, and the installation owner must approve the updated permission.

@ecc-tools

ecc-tools Bot commented Nov 4, 2026

Copy link
Copy Markdown

ECC Tools / Hosted Promotion Readiness

Commit: 00b8ae2e525274a97cc9000dff2d81421caca173

Hosted promotion readiness passed (success)

No hosted promotion evidence gaps detected across 2 changed file(s); 0 corpus scenarios had matching evidence.

This check compares PR file changes against the evaluator/RAG promotion corpus in src/analyzers/fixtures/evaluator-rag-corpus.ts.
Hosted output scoring inspected 0 completed cached hosted job results.

No evaluator corpus scenarios matched this PR.

Check publication was denied or unavailable. An app owner must enable Checks: read and write, and the installation owner must approve the updated permission.

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant