Skip to content

Disambiguate read-interruption members across backends - #845

Merged
Youw merged 1 commit into
masterfrom
backend-specific-read-state
Nov 8, 2026
Merged

Disambiguate read-interruption members across backends#845
Youw merged 1 commit into
masterfrom
backend-specific-read-state

Conversation

@Youw

@Youw Youw commented Nov 8, 2026 •
edited
Loading

Copy link
Copy Markdown
Member

Merged Coverity analysis associated macOS's read_interrupted field with libusb's mutex, producing six false-positive MISSING_LOCK reports. Give the private fields distinct names, mac_read_interrupted and libusb_read_interrupted, while preserving the public API, structure layout and synchronization.

Fresh hosted analysis at e06d86174640743c4e38d12571fe1cbfa7cc0bd1 eliminates all six reports (CIDs 1706118–1706122 and 1706124), with no replacement warnings or newly detected defects. The thread-creation finding also disappears because the base includes #843. Outstanding findings fall from eight to one: CID 1706117, the guarded-index false positive. The active model and defect classifications were unchanged.

Validation:

  • Claude Fable 5.1 found no actionable source issues before captures and submission. Exact-token comparison confirms only 19 member declarations/accesses changed.
  • Fresh captures and submission passed: 7 Windows + 6 macOS + 10 Linux translation units, all 23 preserved with matching 2024.12.1 tools and integrity checks passing.
  • Local libusb C/C++ builds and all active CI checks pass, including GitHub Actions, BSD and AppVeyor. Four conditional jobs were skipped.
  • Hosted results: seven eliminated, zero new, one outstanding.

Related to #841 and #843.

Generated by Codex (GPT-6); reviewed by Claude Fable 5.1.

Assisted-by: Codex:GPT-6
Assisted-by: claude-code:claude-fable-5-1

@Youw
Disambiguate read-interruption members across backends
e06d861 
Give the macOS and libusb private interrupt flags distinct member names
so merged static analysis can distinguish their locking requirements.
Keep layout, API and synchronization unchanged.

Related to #841 and #843.

Assisted-by: Codex:GPT-6
Assisted-by: claude-code:claude-fable-5-1
@Youw
Youw marked this pull request as ready for review November 8, 2026 22:39
@Youw
Youw merged commit e4c4a08 into master Nov 8, 2026
32 checks passed
@Youw
Youw deleted the backend-specific-read-state branch November 8, 2026 22:49
@Youw Youw mentioned this pull request Nov 8, 2026
Merged
Youw added a commit that referenced this pull request Nov 9, 2026
@Youw
libusb/test: clarify trailing hex parser bounds (#846)
418d62a 
Scan trailing hex tokens forward with directly bounded indexes while preserving parser behavior. Extend existing self-tests for metadata, buffer limits and token boundaries.

Related to #845 and #841.

Assisted-by: claude-code:claude-opus-5-5
Assisted-by: claude-code:claude-fable-5-1
Assisted-by: Codex:GPT-6
@mcuee mcuee added macOS Related to macOS backend libusb Related to libusb backend labels Nov 9, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

libusb Related to libusb backend macOS Related to macOS backend

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@Youw @mcuee