Repository navigation
fix: preserve object storage secret keys in table output - #944
Open
pcbeingused333 wants to merge 2 commits into
Open
pcbeingused333 wants to merge 2 commits into
pcbeingused333 wants to merge 2 commits into
Conversation
pcbeingused333
requested review from
mawilk90 and
zliang-akamai
and removed request for
a team
November 9, 2026 01:41
Contributor
There was a problem hiding this comment.
🟡 Changes recommended
Markdown output still truncates the one-time object-storage secret key in narrow terminals because it lacks a truncation-disabling override.
1 open issue
What changed in this PR
This PR addresses #825 by preserving one-time Object Storage secret keys in table and ASCII table output, using the CLI’s existing nontruncating renderer.
Changes:
- Adds
keys-createoverrides that fold long values instead of truncating them. - Adds narrow-terminal tests for complete creation output and unchanged listing behavior.
- Documents the action-specific output behavior.
| File | Description |
|---|---|
tests/unit/test_overrides.py |
Tests key creation and listing output at 28 columns in both table modes. |
linodecli/overrides.py |
Disables truncation for object-storage keys-create in table and ASCII table modes. |
AGENTS.md |
Documents preservation of the one-time secret key. |
Review effort: Max
Comment on lines
+62
to
+71
| @output_override("object-storage", "keys-create", OutputMode.ascii_table) | ||
| def handle_object_storage_keys_create_ascii( | ||
| operation, output_handler, json_data | ||
| ) -> bool: | ||
| # pylint: disable=unused-argument | ||
| """ | ||
| Preserve the complete secret key in ASCII table output as well. | ||
| """ | ||
| output_handler.disable_truncation = True | ||
| return True |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #825
📝 Description
What does this PR do and why is this change necessary?
The default table renderer uses ellipsis when a value exceeds the terminal width. For
object-storage keys-create, this can discard part of the secret key that is only returned at creation time.Add action-specific table and ASCII table output overrides that enable the existing nontruncating renderer. Long keys fold across lines, preserving every character. Other actions retain their existing output behavior.
✔️ How to Test
What are the steps to reproduce the issue or verify the changes?
Run
linode-cli object-storage keys-create --label <label>in a narrow terminal and check thatsecret_keyis shown in full, folded across lines.How do I run the relevant unit/integration tests?
LINODE_CLI_TEST_MODE=1 XDG_CONFIG_HOME=$(mktemp -d) pytest tests/unit/test_overrides.py tests/unit/test_output.pyThe tests render through the response dispatch at a terminal width of 28 columns, checking complete key creation output and unchanged truncation for key listing. No live API call was made.
This change was prepared with AI assistance (Codex).