Repository navigation
chore: bump ch.qos.logback:logback-classic from 1.2.3 to 1.6.6 - #65
dependabot[bot] wants to merge 1 commit into
Conversation
Bumps [ch.qos.logback:logback-classic](https://github.com/qos-ch/logback) from 1.2.3 to 1.6.6. - [Release notes](https://github.com/qos-ch/logback/releases) - [Commits](qos-ch/logback@v_1.2.3...v_1.6.6) --- updated-dependencies: - dependency-name: ch.qos.logback:logback-classic dependency-version: 1.6.6 dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com>
There was a problem hiding this comment.
Nothing blocking. The comments below are optional suggestions. There is no need to push a fix for them before merging.
Apart from the inline findings, I checked whether this bump affects consumers' Java 8 floor. It doesn't: logback-classic is declared only as testImplementation (build.gradle:44), so the published artifact and the sourceCompatibility/targetCompatibility 1.8 pins are unchanged.
Extended reasoning...
The change bumps one version string in build.gradle: the test-only logback-classic goes from 1.2.3 to 1.6.6. It touches no security-sensitive code. Because logback 1.6.x needs a newer JDK than Java 8, I checked the dependency's scope and found it is test-only, so the newer JDK requirement affects only the JDK 17 test build and not consumers.
| slf4j_core_version = "1.6.3" | ||
| slf4j_classic_version = "1.2.3" | ||
| slf4j_classic_version = "1.6.6" |
There was a problem hiding this comment.
🟡 nit (optional): After this bump, build.gradle declares two different logback versions: logback-classic at 1.6.6 and logback-core at 1.6.3. The two are released together as a matched pair. Gradle quietly resolves logback-core to 1.6.6 through logback-classic's own dependency, so slf4j_core_version = "1.6.3" no longer says what the tests actually run with. Fix: bump slf4j_core_version to "1.6.6" as well. Better still, drive both artifacts from a single logback_version variable so later Dependabot bumps cannot split them.
Why this was flagged
build.gradle:43 uses slf4j_core_version (still "1.6.3") for ch.qos.logback:logback-core. build.gradle:44 now uses slf4j_classic_version ("1.6.6") for ch.qos.logback:logback-classic. On the base branch both declarations were older but separate as well. This PR makes the two halves of one library disagree on patch level. With a plain version string, Gradle's conflict resolution upgrades logback-core to the 1.6.6 that logback-classic requires transitively, so test runs still work. The declared 1.6.3 is therefore stale and misleading. A later edit that pins it strictly, or a separate Dependabot PR for logback-core, could leave mismatched logback-core/logback-classic jars on the test classpath. Only test scope is affected, and published consumers are not.
Verification: In build.gradle, line 29 still has slf4j_core_version = "1.6.3", which line 43 uses for logback-core. Line 30 now has slf4j_classic_version = "1.6.6", which line 44 uses for logback-classic. Gradle's default conflict resolution picks the highest version, so the test classpath gets logback-core 1.6.6. This PR is what makes line 43 a dead declaration.
Finding ID: f-687bddef
| json_fire_version = "1.8.0" | ||
| slf4j_core_version = "1.6.3" | ||
| slf4j_classic_version = "1.2.3" | ||
| slf4j_classic_version = "1.6.6" |
There was a problem hiding this comment.
🟡 nit (optional): This bump adds no CHANGELOG.md entry, so the next release note will not mention it. AGENTS.md and CONTRIBUTING.md:52 ask every change to add a line under ## [Unreleased], because release automation only renames that heading. Fix: add a line under ## [Unreleased] in CHANGELOG.md, e.g. "Bump test dependency ch.qos.logback:logback-classic from 1.2.3 to 1.6.6". Put it under a section such as ### Fixed, which earlier releases used for non-API changes like "Pin conventional commits (#21)".
Why this was flagged
The diff changes only build.gradle:30 (slf4j_classic_version "1.2.3" -> "1.6.6"). CHANGELOG.md is untouched, and its ## [Unreleased] heading at CHANGELOG.md:8 is still empty. AGENTS.md:81-84 and CONTRIBUTING.md:52 say release automation only renames ## [Unreleased] and never writes entries, so a change with no entry ships with an empty release note. Once this merges, the next release's notes leave out this dependency change. The base branch has no such gap because the change does not exist there. No CI check enforces changelog entries, and Dependabot PRs are exempt from the title and branch checks (AGENTS.md Gotchas 3), so nothing catches the omission.
Verification: Severity: nit. The trigger is merging this PR as it stands, which changes only slf4j_classic_version = "1.2.3" to "1.6.6" at build.gradle line 30. CHANGELOG.md is untouched, and its ## [Unreleased] heading at CHANGELOG.md:8 has no entries. AGENTS.md:81-83 and CONTRIBUTING.md:52 require a hand-written entry. The next release note leaves out this bump.
Finding ID: f-f1f2d09d
Bumps ch.qos.logback:logback-classic from 1.2.3 to 1.6.6.
Release notes
Sourced from ch.qos.logback:logback-classic's releases.
... (truncated)
Commits
a9ee801prepare release 1.6.67fa8e8ethrow ScanException on unmatched '}' during variable substitution, fixes #836355b931Test round trip of circular exceptions through LoggingEventVOc7b8e2freject cyclic throwable proxies in LoggingEventVO.readObject6217f11fix loging of ThrowableProxy constructor taking isCyclic boolean0b95858LOGBACK-1337 LogbackMDCAdapter should store mdc in LinkedHashMap to predict o...5c1f577add LinkedHashMap to HardenedObjectInputStream whitelist7c36c71Escape regex metacharacters in date patterns, harden rolling testsd268774Align date pattern to regex conversion with DateTimeFormatterb4b4828Escape regex metacharacters of literal text in FileNamePattern regexesDependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting
@dependabot rebase.Dependabot commands and options
You can trigger Dependabot actions by commenting on this PR:
@dependabot rebasewill rebase this PR@dependabot recreatewill recreate this PR, overwriting any edits that have been made to it@dependabot show <dependency name> ignore conditionswill show all of the ignore conditions of the specified dependency@dependabot ignore this major versionwill close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this minor versionwill close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this dependencywill close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)