Repository navigation
Fix send-failure callbacks racing message delivery - #635
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A failed send currently invokes Close on the sending thread while the connection thread may still be inside a Message callback. This can overlap callbacks and deliver messages after Close.
Use the existing close path: fatal writes, write-readiness errors, and send timeouts call close(1006, reason). An abnormal close discards pending output and wakes the connection thread without sending a Close frame. The active Message callback finishes; further buffered data callbacks are suppressed while CLOSING, as with an explicit close. The connection thread closes the socket and delivers the final Close callback. CLOSED is published before the callback so reentrant close() is safe.
This uses the existing state, close code, and close reason, with no additional member variables. The first close request retains its code/reason, and timeout/cancellation behavior remains covered by tests. Production code remains C++11 compatible.
Closes #551.
Validation: