Repository navigation
Conversation
The test's final sync loop started with an initial sync, so whether it exercised initial or incremental sync depended on when the rescission arrived. It now waits for the rescission with an incremental sync, then checks that a fresh initial sync also includes it. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01FqDpJa1cp5hHXwmcMbEPJm
Contributor
Author
|
This will fail until element-hq/synapse#20453 is merged. |
3 tasks done
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In the existing test, Bob would start with an initial sync after Alice kicks them from the room. Depending on environment timings, Bob's server could have received the kick either before the initial sync, or after.
Because the sync logic is different for an initial sync vs an incremental sync, this would lead to intermittent failures in Synapse where Bob would see the leave only some of the time.
element-hq/synapse#20453 is a fix on the Synapse side.
This PR changes the complement test to ensure deterministic testing by:
Pull Request Checklist