Repository navigation
Select desktop stories directly and attribute per-case E2E time - #4496
Jason Morse (JasonVMo) wants to merge 7 commits into
Conversation
Bundle size reportTree-shaken, minified production esbuild bundles with React and React Native runtimes externalized.
The job is advisory: size changes are reported but do not fail the pull request. Bundle or analysis errors still fail. |
Windows portable finding — W5 (desktop measurements to follow)Reproduced at Source and reproduction
From the candidate checkout root in PowerShell: Push-Location .\packages\agentic\storybook-desktop
yarn build
Pop-Location
@'
import { strict as assert } from 'node:assert';
import { summarizeWindowActivity } from './packages/agentic/storybook-desktop/lib/testing/runDiagnostics.js';
const activity = summarizeWindowActivity({
source: 'WinEvent', observing: true, eventsTruncated: false,
events: [
{ ageMs: 1, element: 'fixture-window', notification: 'EVENT_SYSTEM_FOREGROUND', sequence: 1 },
{ ageMs: 0, element: 'fixture-window', notification: 'EVENT_OBJECT_CREATE', sequence: 2 },
],
});
console.log(JSON.stringify(activity, null, 2));
assert.ok(
activity.status !== 'observed' || typeof activity.windowsCreated !== 'number',
'An unsupported AX-only counter must not be presented as an observed Windows number',
);
'@ | yarn node --input-type=moduleObserved: Expected: retain genuinely supported generic observations such as the two events, but omit unsupported AX-only counters or explicitly mark them unsupported. Alternatively, conservatively return Gate and suggested fixThis fails the diagnostic-degradation gate: Windows-only gaps must be absent or explicitly unsupported, never fabricated numeric zeros under an “observed” status. It is not evidence that Windows had zero activity and is not, by itself, a story-navigation failure. Make the projection source-aware. Preserve the existing AX projection for The existing focused portable suites passed (209 tests, one Windows SIGHUP skip), but lack this WinEvent assertion. Windows Fabric / Win32 Paper desktop measurements and live correctness results remain Not run, awaiting the Windows coordinator's W5 campaign grant. Those results will follow in a separate comment. No source change or push was made to this branch. |
Part of #4435. Record bounded local selection, worker, cleanup and native-activity diagnostics without changing navigation or remount isolation. Capture the eight-run Fabric baseline and its observation limits. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Part of #4435. Preserve independent server/provider foreground and hit-test checks while concurrent physical-input corrections are qualified; record the non-activating popup-read proposal without changing native semantics. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
…r run Part of #4435. Separate dispatch from protected policy, preserve authenticated readiness and per-case remount/session/worker isolation, and recheck source hashes plus manifest digests on cached extractions. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Part of #4435. Record eight-run baseline/candidate measurements for both macOS renderers, sparse accessible/physical qualification, native contracts, recording limits, deferred gates, and final aggregate results without claiming a flashing or reliability improvement. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Revalidate observed helper dependencies on cache hits, separate process history from per-case event loss, remove synthetic mount counts, and document failed-attempt timings. Record plain parallel aggregate failures reproduced on the stacked base. Part of #4435 Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
95a8129 to
389a518
Compare
PARTIAL — Windows Fabric paired qualification, W5No speedup is claimed on Windows Fabric. The scoped prepared-lifecycle The RDP session disconnected/locked during the restart experiment at Pins, protocol and scope
Windows Fabric measurementsAll values in this table are seconds. Each arm has 16 lifecycle samples.
The median paired difference is not the difference of the two arm medians. Authored cases are a separate pooled comparison, 48 cases per arm:
Root-cause analysis from retained artifacts onlyHigh confidence: this is concentrated in the first navigation, not a
Among the later 214 stories, 138 have negative paired-median deltas, 54 Observed localization within that cold first navigation: producer-timestamped
Using means, which can be added, +4.283 s of the +4.786 s first-navigation Code-based interpretation, not a proven candidate-code cause: The candidate chooses direct transport at Additional phase checks:
If desktop work resumes, a separately declared warm-runtime/cache-balanced Windows correctnessEvery Win32 entry below means Not run (session disconnected 00:39:47Z),
Normal candidate accessible context generations are 2, 3, 4; scoped Scoped physical run IDs are A D1 remains reproduced: the early Windows finding Delay proposals — both shipping defaults retained
Reproduction and retained evidenceUnder the W5 campaign, Portable reanalysis commands, from the candidate worktree: node artifacts\desktop\w5-campaign-20261112\analyze-navigation.mjs
node artifacts\desktop\w5-campaign-20261112\analyze-cold-start.mjs
node artifacts\desktop\w5-campaign-20261112\analyze-common-workers.mjsAll passed on retained reports only. Each asserts the expected cohort and The campaign is ended, the W5 grant remains unchanged, and the recorded |
…onvmo/desktop-e2e-refresh-reduction # Conflicts: # packages/agentic/desktop-driver/references/current-status.md Co-authored-by: JasonVMo <35609178+JasonVMo@users.noreply.github.com>
|
Copilot resolve the merge conflicts on this branch. |
…onvmo/desktop-e2e-refresh-reduction # Conflicts: # packages/agentic/desktop-driver/references/current-status.md Co-authored-by: JasonVMo <35609178+JasonVMo@users.noreply.github.com>
The branch already includes current |
Platforms Impacted
Description of changes
Part of #4435. Stacked on #4490 (base
user/jasonvmo/desktop-manifest-trustataadc2f359); review only this layer's diff.Reduces desktop E2E per-case overhead without weakening isolation. Remounts stay on by default, and every case keeps a fresh Node worker and WebDriver session, a fresh authenticated context, and native-marker verification.
runDiagnostics,runWdioTests,worker; desktop-driversessionStories/storybook):StorybookChannelOrchestrator):controlledprotection policy. Normal args support and protected-agent args refusal/no-relay are preserved, and direct library consumers keep the legacy HTTP default.wdioExtractionCache):desktop-driver/references/remaining-work.md). No safe activation dedupe was established, so this PR does not change activation.Docs: storybook-desktop README,
references/{readiness,story-tests,current-status}.md; desktop-driverreferences/{protocol,remaining-work,current-status}.md. Changeset:calm-story-observations.md(patch: desktop-driver, storybook-desktop).Verification
Local macOS, under a machine-wide native lock. Paired baseline (
aadc2f359) and candidate runs used identical selected cases, ordering, input lane and renderer: eight runs per side and renderer, 24 passing callbacks plus eight declared unsupported. Times are runner-only, in ms.These are sequential blocks from a small cohort, so they make no reliability or startup claim. Native-verification p95 got worse. Window-scoped recordings could not support any claim of reduced flashing. The full statistics and their limits are in
storybook-desktop/references/current-status.md.yarn test …)--input accessibleand sparse physical--self-test,FURN_NATIVE_DRIVER_TEST=1contractsyarn oxfmt --check,yarn check-agent-instructions,yarn markdown-link-checkon changed docs,yarn change:checkyarn clean-lage-cache && yarn lage buildci(plain, parallel Jest)boundedCommandSIGKILL/SIGTERMassertion. The same command on baseaadc2f359fails the same way, plus aprivateStoragetimeout, so this predates this PR. Local Node 24, heavy machine load.95a81290c(direct selection plus extraction cache on every Storybook lane)bridge-unavailablestderr navigation lines also appear, at the same count, on base #4490 (existing log noise).One Opus 5.5 review: no blockers; five minor findings, all fixed in
95a81290c.Pull request checklist
This PR has considered (when applicable):