Repository navigation
fix: walk /proc/self/fd when close_range is not available - #1012
Open
Konstantin Adzer (AdzerKI) wants to merge 1 commit into
Open
Konstantin Adzer (AdzerKI) wants to merge 1 commit into
Konstantin Adzer (AdzerKI) wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1011
Without
close_range,pty_close_inherited_fds()now sets FD_CLOEXEC on every fd listed in/proc/self/fd, read withgetdents64sincereaddir()may allocate in the forked child. The existing loop stays for when/procis not available.The leak test now opens and closes a block of fds before spawning the third pty, so the masters of the first two sit above a gap. Built against the glibc 2.28 sysroot as CI does, it fails without the change (3 ptmx fds in the shell) and passes with it;
npm testand lint are green.