Skip to content

fix(settings): show web search setup progress and elapsed time - #389

Merged
Angnuo (angnuoli) merged 1 commit into
microsofthackathons:mainfrom
angnuoli:codex/search-setup-progress
Nov 17, 2026
Merged

Angnuo (angnuoli) merged 1 commit into
microsofthackathons:mainfrom
angnuoli:codex/search-setup-progress

Conversation

@angnuoli

@angnuoli Angnuo (angnuoli) commented Nov 17, 2026 •

Copy link
Copy Markdown
Collaborator

Description

Enabling web search can take tens of seconds while the component is installed and the configuration takes effect. The settings page currently shows only "Saving...", making it difficult to tell whether preparation is progressing.

Show the current stage and elapsed time in the existing upper-right status, for example 安装组件 · 22 秒 / Installing component · 22s. Keep the existing layout and saved/error states, with no details panel or extra controls.

Related Issue

None.

Changes

  • Forward actual plugin installation activities and configuration/readiness stages through request-correlated Gateway and renderer events.
  • Display localized stage labels and a monotonic elapsed timer. Time alone never advances the stage.
  • Ignore unrelated or stale progress and clean up timers/listeners after completion, failure, edits, and unmount.
  • Cover request matching, timeout/disconnect cleanup, existing-component reuse, and renderer lifecycle behavior.

Type of Change

  • Bug fix (non-breaking change that fixes an issue)

Testing

Validated in an isolated worktree based on upstream c64b2f56:

  • Full desktop suite: npm test --prefix desktop -- --maxWorkers=4 — 2,705 passed, 56 skipped, 2 failed. The two failures are in the unchanged github-copilot-login-timing.test.ts: the synthetic failure case throws during manager.stop(), and the cancellation case times out waiting for a code event. The Copilot timing tests and implementation are identical to the upstream base. Search progress tests pass.
  • npm test --prefix desktop/renderer -- --maxWorkers=4 — 1,159 passed, 2 skipped across 62 test files.
  • npm run build --prefix desktop — passed, including TypeScript and Vue type checking.
  • npm run lint — passed with warnings.
  • npm run format:check — passed.
  • Manual live-provider installation — not rerun; progress behavior is exercised with Gateway event fixtures and component tests.

The first desktop-suite attempt hit concurrent Electron auto-installation errors in the fresh dependency tree. Electron was installed explicitly before the reported rerun.

Checklist

  • Code follows the project's guidelines and has been self-reviewed.
  • Added tests cover the behavior and cleanup paths.
  • The PR contains only the web-search setup progress change.
  • Documentation: no configuration or setup workflow changes; user-facing labels are provided in English and Chinese.

@angnuoli
Angnuo (angnuoli) merged commit 38e8efb into microsofthackathons:main Nov 17, 2026
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant