Repository navigation
fix(settings): show web search setup progress and elapsed time - #389
Merged
Angnuo (angnuoli) merged 1 commit intoNov 17, 2026
Merged
Angnuo (angnuoli) merged 1 commit into
Angnuo (angnuoli) merged 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Enabling web search can take tens of seconds while the component is installed and the configuration takes effect. The settings page currently shows only "Saving...", making it difficult to tell whether preparation is progressing.
Show the current stage and elapsed time in the existing upper-right status, for example
安装组件 · 22 秒/Installing component · 22s. Keep the existing layout and saved/error states, with no details panel or extra controls.Related Issue
None.
Changes
Type of Change
Testing
Validated in an isolated worktree based on upstream
c64b2f56:npm test --prefix desktop -- --maxWorkers=4— 2,705 passed, 56 skipped, 2 failed. The two failures are in the unchangedgithub-copilot-login-timing.test.ts: the synthetic failure case throws duringmanager.stop(), and the cancellation case times out waiting for a code event. The Copilot timing tests and implementation are identical to the upstream base. Search progress tests pass.npm test --prefix desktop/renderer -- --maxWorkers=4— 1,159 passed, 2 skipped across 62 test files.npm run build --prefix desktop— passed, including TypeScript and Vue type checking.npm run lint— passed with warnings.npm run format:check— passed.The first desktop-suite attempt hit concurrent Electron auto-installation errors in the fresh dependency tree. Electron was installed explicitly before the reported rerun.
Checklist