Skip to content

perf(installer): align runtime helper thread pool with extraction - #392

Merged
Angnuo (angnuoli) merged 1 commit into
microsofthackathons:mainfrom
angnuoli:codex/installer-runtime-threadpool-20261117
Nov 17, 2026
Merged

Angnuo (angnuoli) merged 1 commit into
microsofthackathons:mainfrom
angnuoli:codex/installer-runtime-threadpool-20261117

Conversation

@angnuoli

@angnuoli Angnuo (angnuoli) commented Nov 17, 2026 •

Copy link
Copy Markdown
Collaborator

Description

The installer launches the desktop runtime-preparation helper without an application default for its libuv thread pool, while the archive extractor uses eight file consumers. Set UV_THREADPOOL_SIZE=8 in the helper environment before process startup so the two are aligned, preserving any explicit user setting.

Related Issue

None.

Changes

  • Add a helper-process environment default with setdefault; the parent process environment is unchanged.
  • Keep this change limited to deployer/windows_setup.py (3 added lines).

Type of Change

  • Performance improvement / build configuration change

Testing

  • 26 existing installer-runtime and bundled-installer tests passed.
  • Verified the helper receives 8 when unset and preserves an explicit value of 12, without changing the parent environment.
  • Ruff 0.16.3 lint and formatting checks passed for the changed file.
  • Full Python test suite passed: 583 tests run, 6 skipped.
  • JS/TS CI lint, formatting, and unit tests passed.
  • Windows packaging (not required to finish before the requested manual merge)

No new end-to-end installation performance numbers are claimed by this PR.

Checklist

  • Self-review completed; the extractor's FILE_CONCURRENCY is 8.
  • Existing installer behavior and explicit environment overrides are preserved.
  • Documentation changes are not required for this internal helper default.

@angnuoli
Angnuo (angnuoli) merged commit 7222f96 into microsofthackathons:main Nov 17, 2026
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant