Skip to content

refactor: tabbedmodal responsiveness - #8235

Open
IMB11 wants to merge 3 commits into
mainfrom
cal/responsiveness-tabbed-modal-changes
Open

IMB11 wants to merge 3 commits into
mainfrom
cal/responsiveness-tabbed-modal-changes

Conversation

@IMB11

@IMB11 IMB11 commented Nov 5, 2026

Copy link
Copy Markdown
Member
  • some fixes to responsiveness regressions noticed on the server panel

@IMB11
IMB11 requested a review from Prospector November 5, 2026 15:45
@github-actions

github-actions Bot commented Nov 5, 2026

Copy link
Copy Markdown
Contributor

Pull request changelog

App

Added

Changed

Deprecated

Removed

Fixed

Security

Website

Added

Changed

Deprecated

Removed

Fixed

Security

Hosting

Added

Changed

Deprecated

Removed

Fixed

Security

@greptile-apps

greptile-apps Bot commented Nov 5, 2026 •

Copy link
Copy Markdown

RetriggerView in GreptileConfidence Score: 5/5

[Medium impact] The latest changes appear safe to merge; the remaining debug logging is non-blocking.

Summary

The PR adds mobile sheets, a collapsible sidebar, and mobile cards for server settings.

  • Tabbed settings dialogs adapt their layout to the screen.
  • Server settings use cards and controls that fit narrow screens.
  • Sharing pages show invite details in cards on small screens.

Reviews (2) · Last reviewed commit: "refactor: cleanup tabbedmodal changes + ..." · Reviewed by Greptile

@github-actions

github-actions Bot commented Nov 5, 2026 •

Copy link
Copy Markdown
Contributor

Frontend previews

Last deployed commit is 1cf5150a6a8fbffe4052afa75fd3eb44f83ea255

Persistent

Environment URL
staging https://pr-8235.frontend-staging.rinth.dev
production https://pr-8235.frontend.rinth.dev
storybook https://pr-8235-storybook.modrinth.workers.dev

Latest commit

Environment URL
staging https://e6090995.frontend-staging.rinth.dev
production https://17efa931.frontend.rinth.dev

@IMB11

IMB11 commented Nov 5, 2026

Copy link
Copy Markdown
Member Author

@greptileai review

@IMB11

IMB11 commented Nov 5, 2026

Copy link
Copy Markdown
Member Author

@Mergifyio queue

@mergify

mergify Bot commented Nov 5, 2026 •

Copy link
Copy Markdown

🚫 Left the queue · pull request dequeued

11 min in the queue, with no time running CI.

So far

Reason

Pull request #8235 has been dequeued

Mergify failed to merge the pull request. GitHub can't merge the pull request after 10 minutes of retrying.

Head branch is out of date

To get back in the queue

  • Push a change if one is needed: the pull request is queued again once its queue conditions match.
  • If no change is needed, tick the box below to queue it again as it is.

Tick the box to put this pull request back in the merge queue (same as @mergifyio queue).

  • Requeue this pull request
2 merge conditions met
  • github-review-approved · required by GitHub branch protection
  • any of · required by GitHub branch protection:
    • check-skipped = Lint and Test
    • check-neutral = Lint and Test
    • check-success = Lint and Test

Times in UTC · dashboard · how the merge queue works

@mergify mergify Bot added the queued label Nov 6, 2026
@mergify mergify Bot mentioned this pull request Nov 6, 2026
6 of 10 tasks
@mergify mergify Bot added dequeued and removed queued labels Nov 6, 2026

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Development

Successfully merging this pull request may close these issues.

2 participants