Repository navigation
Conversation
moetemp
force-pushed
the
moe/brook/review/s5-client-reads
branch
from
October 26, 2026 00:14
252b606 to
b70af4e
Compare
moetemp
force-pushed
the
moe/brook/review/s6-redis-memory
branch
2 times, most recently
from
October 26, 2026 02:08
326073b to
d018d29
Compare
moetemp
force-pushed
the
moe/brook/review/s5-client-reads
branch
from
October 26, 2026 02:08
b70af4e to
50134b6
Compare
moetemp
force-pushed
the
moe/brook/review/s6-redis-memory
branch
from
October 26, 2026 08:44
d018d29 to
b5bb616
Compare
moetemp
force-pushed
the
moe/brook/review/s5-client-reads
branch
from
October 26, 2026 08:44
50134b6 to
6636d64
Compare
moetemp
force-pushed
the
moe/brook/review/s6-redis-memory
branch
from
October 27, 2026 09:07
b5bb616 to
f5a8d77
Compare
moetemp
force-pushed
the
moe/brook/review/s5-client-reads
branch
2 times, most recently
from
October 27, 2026 09:17
86ae5d2 to
c774176
Compare
moetemp
force-pushed
the
moe/brook/review/s6-redis-memory
branch
from
October 27, 2026 09:17
f5a8d77 to
6d49da8
Compare
moetemp
force-pushed
the
moe/brook/review/s5-client-reads
branch
from
October 28, 2026 01:33
c774176 to
fe0790c
Compare
moetemp
force-pushed
the
moe/brook/review/s6-redis-memory
branch
from
October 28, 2026 01:33
6d49da8 to
026e0a3
Compare
moetemp
force-pushed
the
moe/brook/review/s5-client-reads
branch
from
October 28, 2026 07:54
fe0790c to
62769cb
Compare
moetemp
force-pushed
the
moe/brook/review/s6-redis-memory
branch
2 times, most recently
from
October 28, 2026 08:05
11cd676 to
c68482a
Compare
moetemp
force-pushed
the
moe/brook/review/s5-client-reads
branch
from
October 28, 2026 08:05
62769cb to
7265a04
Compare
moetemp
force-pushed
the
moe/brook/review/s6-redis-memory
branch
2 times, most recently
from
November 5, 2026 23:10
b445a38 to
27b6d1c
Compare
moetemp
force-pushed
the
moe/brook/review/s5-client-reads
branch
from
November 5, 2026 23:10
7104162 to
4b9c1eb
Compare
moetemp
force-pushed
the
moe/brook/review/s5-client-reads
branch
from
November 6, 2026 09:06
4b9c1eb to
1d4d038
Compare
moetemp
force-pushed
the
moe/brook/review/s6-redis-memory
branch
from
November 6, 2026 09:06
27b6d1c to
06f4615
Compare
moetemp
force-pushed
the
moe/brook/review/s6-redis-memory
branch
from
November 6, 2026 09:22
06f4615 to
84bc88f
Compare
Owner
Author
|
Closed in favor of #381, the combined branch, which has this change. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What was changed
This PR adds the Redis Stream backend (
temporalio.contrib.stream.RedisStreamBackend) and the in-memory backend for tests (temporalio.contrib.stream.testing.MemoryStreamBackend).Client.create_stream, which takesbackend=for a backend that isn't the default. The package has no create of its own.temporalio-streamsruntime that [Brook B1] Added thestreamsbridge feature that links thetemporalio-streamscrate. #370 links. The memory backend has Redis's rules, so tests can swap the Store with no other change.temporalio.runtime.Runtimeshare one Redis runtime object and its connections. So a service that makes a client for each tenant opens no more connections.safety_ttlapplies only to an open Stream bound to a Workflow, which this SDK doesn't create yet.redis-serveron Linux and macOS, where the Redis lane fails instead of skipping. Redis has no official Windows build, so the lane skips there.redis-server, or useTEMPORAL_STREAMS_REDIS_URL.Why?
These are the first backends that run. From here on, the tests run live on both Stores.
Open question.
ExtensionStreamBackendis a public class in a private module, as the base of both backends. Is that OK?Part of the Streams review series.
Checklist
poe lintandpytest tests/contrib/streamson both backends, with Redis required.