Repository navigation
Conversation
1 of 3 tasks
moetemp
force-pushed
the
moe/brook/review/s9-examples
branch
from
October 26, 2026 00:14
55f7a0d to
c4f1ffc
Compare
moetemp
force-pushed
the
moe/brook/review/s8-activity-handles
branch
from
October 26, 2026 02:08
223a99b to
fa0c9d3
Compare
moetemp
force-pushed
the
moe/brook/review/s9-examples
branch
from
October 26, 2026 02:08
c4f1ffc to
ca1e58d
Compare
moetemp
force-pushed
the
moe/brook/review/s8-activity-handles
branch
from
October 26, 2026 04:13
fa0c9d3 to
24f6a90
Compare
moetemp
force-pushed
the
moe/brook/review/s9-examples
branch
2 times, most recently
from
October 26, 2026 04:52
3029be1 to
ed9287d
Compare
moetemp
force-pushed
the
moe/brook/review/s8-activity-handles
branch
2 times, most recently
from
October 26, 2026 08:44
79cf55a to
15eebd7
Compare
moetemp
force-pushed
the
moe/brook/review/s9-examples
branch
2 times, most recently
from
October 27, 2026 09:07
0bb4d28 to
ed58b77
Compare
moetemp
force-pushed
the
moe/brook/review/s8-activity-handles
branch
from
October 27, 2026 09:07
15eebd7 to
b3da39a
Compare
moetemp
force-pushed
the
moe/brook/review/s9-examples
branch
from
October 27, 2026 09:17
ed58b77 to
3afa400
Compare
moetemp
force-pushed
the
moe/brook/review/s8-activity-handles
branch
from
October 27, 2026 09:17
b3da39a to
212ef71
Compare
moetemp
force-pushed
the
moe/brook/review/s9-examples
branch
2 times, most recently
from
October 28, 2026 07:54
98dc9dc to
e237cb7
Compare
moetemp
force-pushed
the
moe/brook/review/s8-activity-handles
branch
from
October 28, 2026 08:05
0c7ec5b to
86d50a1
Compare
moetemp
force-pushed
the
moe/brook/review/s9-examples
branch
from
October 28, 2026 08:05
e237cb7 to
0bf1696
Compare
moetemp
force-pushed
the
moe/brook/review/s8-activity-handles
branch
from
November 5, 2026 17:19
7fd6dcb to
ee23c91
Compare
moetemp
force-pushed
the
moe/brook/review/s9-examples
branch
2 times, most recently
from
November 5, 2026 23:10
b64ebb5 to
d321f7a
Compare
moetemp
force-pushed
the
moe/brook/review/s8-activity-handles
branch
from
November 6, 2026 09:06
0d2120b to
b346382
Compare
moetemp
force-pushed
the
moe/brook/review/s9-examples
branch
2 times, most recently
from
November 6, 2026 09:22
06f603e to
f3ca1f0
Compare
moetemp
force-pushed
the
moe/brook/review/s8-activity-handles
branch
from
November 6, 2026 10:11
058106a to
1b71cf6
Compare
moetemp
force-pushed
the
moe/brook/review/s9-examples
branch
from
November 6, 2026 10:11
f3ca1f0 to
e7b444e
Compare
Owner
Author
|
Closed in favor of #381, the combined branch, which has this change. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What was changed
This PR adds the Stream examples and the end-to-end Redis tests, the module doc of
temporalio.streams, the Streams changelog fragment and a CODEOWNERS entry.client.get_stream[Turn](chat_id), and matches onr.kind, which narrows the item's type. Its read ends when the creator closes the Stream at the end ofasync with.workflow.to_stream(ref), and passes the same ref on to an Activity.streamquery that returnsNonebefore the create, and forwards both refs at continue-as-new. It publishes the done Turn with the reply, then closes, since a close carries no value.activity.client().to_stream, and uses a fake model client in place of a model call. Its sync Activity is a method of a class that keeps the Worker's client, since a sync Activity has noactivity.client().worker_setup.pysays that a Worker serves only one backend. Its test checks that a Worker on the migration's client with two backends raisesStreamConfigError.Why?
After this PR,
feature-streamshas the whole API. Upstream mergesfeature/streamsintomainonce, somainnever has half an API. The examples are the API docs until the docs site has Streams.Open question. CODEOWNERS gives the AI SDK team and the SDK team the Streams paths,
temporalio/streams/included. Which team owns them?Part of the Streams review series.
Checklist
poe lint,poe gen-docs, a regeneration that leaves no diff, the Streams suite on both backends with Redis, and the client, converter, bridge, Replayer, plugin and Nexus caller suites.