Repository navigation
Fix CI: docs deploy action and CodeQL JDK 8 toolchain - #342
Merged
Merged
Conversation
- sdk-reference: replace cloudflare/pages-action (removed from GitHub,
"Unable to resolve action") with cloudflare/wrangler-action v4.1.3,
pinned to a commit SHA, running `pages deploy`.
- settings.gradle.kts: add the foojay toolchain resolver so Gradle can
download the JDK 8 toolchain required by jvmToolchain(8). GitHub's
ubuntu-latest image no longer ships JDK 8, which breaks CodeQL
autobuild ("No matching toolchains found").
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #342 +/- ##
=========================================
Coverage 83.72% 83.72%
Complexity 486 486
=========================================
Files 44 44
Lines 1358 1358
Branches 115 115
=========================================
Hits 1137 1137
Misses 149 149
Partials 72 72 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
tareeqa
self-requested a review
November 5, 2026 14:00
tareeqa
approved these changes
Nov 5, 2026
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Two CI checks fail on every PR (e.g. #341) and on
main, due to changes outside this repo. This PR has no SDK code changes.docsfails during setup:Unable to resolve action cloudflare/pages-action, not found. That action repository was removed from GitHub. This PR replaces it withcloudflare/wrangler-actionv4.1.3, pinned to a commit SHA, runningpages deploy build/dokka/htmlwith the same project, branch and secrets. The environment URL now comes from the action'sdeployment-urloutput.Analyze (java-kotlin)(CodeQL) fails:No matching toolchains found for requested specification: {languageVersion=8 ...}. GitHub'subuntu-latestimage no longer ships JDK 8, and CodeQL default setup autobuilds withoutsetup-java. Our build requiresjvmToolchain(8). Scheduled CodeQL runs onmainhave failed since 2026-10-25. This PR adds Gradle's officialfoojay-resolver-conventionplugin (0.8.0) tosettings.gradle.kts, so Gradle downloads JDK 8 when it is missing. Environments that already have JDK 8 are unaffected.[Unreleased]→ Fixed.Test plan
-Porg.gradle.java.installations.auto-detect=false). Without the fix the build fails with the sameNo matching toolchains founderror../gradlew clean build :examples:compileJavasucceeded (lint and all tests).docscheck on this PR deploys to Cloudflare Pages via wrangler-action.Analyze (java-kotlin)passes on this PR.License
I confirm that this contribution is made under the terms of the MIT license and that I have the authority necessary to make this contribution on behalf of its copyright owner.
🤖 Generated with Claude Code