Skip to content

Fix CI: docs deploy action and CodeQL JDK 8 toolchain - #342

Merged
googsvg merged 2 commits into
mainfrom
ci-fix-docs-deploy-and-codeql-jdk8
Nov 5, 2026
Merged

googsvg merged 2 commits into
mainfrom
ci-fix-docs-deploy-and-codeql-jdk8

Conversation

@googsvg

@googsvg googsvg commented Nov 5, 2026 •

Copy link
Copy Markdown
Contributor

Summary

Two CI checks fail on every PR (e.g. #341) and on main, due to changes outside this repo. This PR has no SDK code changes.

  • docs fails during setup: Unable to resolve action cloudflare/pages-action, not found. That action repository was removed from GitHub. This PR replaces it with cloudflare/wrangler-action v4.1.3, pinned to a commit SHA, running pages deploy build/dokka/html with the same project, branch and secrets. The environment URL now comes from the action's deployment-url output.
  • Analyze (java-kotlin) (CodeQL) fails: No matching toolchains found for requested specification: {languageVersion=8 ...}. GitHub's ubuntu-latest image no longer ships JDK 8, and CodeQL default setup autobuilds without setup-java. Our build requires jvmToolchain(8). Scheduled CodeQL runs on main have failed since 2026-10-25. This PR adds Gradle's official foojay-resolver-convention plugin (0.8.0) to settings.gradle.kts, so Gradle downloads JDK 8 when it is missing. Environments that already have JDK 8 are unaffected.
  • Changelog entry under [Unreleased] → Fixed.

Test plan

  • Reproduced the CodeQL failure locally by hiding the installed JDKs (-Porg.gradle.java.installations.auto-detect=false). Without the fix the build fails with the same No matching toolchains found error.
  • With the fix and the same flag: Gradle provisioned JDK 8, and ./gradlew clean build :examples:compileJava succeeded (lint and all tests).
  • docs check on this PR deploys to Cloudflare Pages via wrangler-action.
  • Analyze (java-kotlin) passes on this PR.

License

I confirm that this contribution is made under the terms of the MIT license and that I have the authority necessary to make this contribution on behalf of its copyright owner.

🤖 Generated with Claude Code

- sdk-reference: replace cloudflare/pages-action (removed from GitHub,
  "Unable to resolve action") with cloudflare/wrangler-action v4.1.3,
  pinned to a commit SHA, running `pages deploy`.
- settings.gradle.kts: add the foojay toolchain resolver so Gradle can
  download the JDK 8 toolchain required by jvmToolchain(8). GitHub's
  ubuntu-latest image no longer ships JDK 8, which breaks CodeQL
  autobuild ("No matching toolchains found").

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@codecov-commenter

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 83.72%. Comparing base (32d7aec) to head (ddcaa25).

Additional details and impacted files
@@            Coverage Diff            @@
##               main     #342   +/-   ##
=========================================
  Coverage     83.72%   83.72%           
  Complexity      486      486           
=========================================
  Files            44       44           
  Lines          1358     1358           
  Branches        115      115           
=========================================
  Hits           1137     1137           
  Misses          149      149           
  Partials         72       72           

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@tareeqa
tareeqa self-requested a review November 5, 2026 14:00
@googsvg
googsvg merged commit f1b2855 into main Nov 5, 2026
5 checks passed

This branch was successfully deployed

1 active deployment
sdk-reference — ddcaa25f Deployed Nov 5, 2026 by googsvg via docs #535
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants