Repository navigation
fix #2156 arrow-reverse marker types - #2480
Open
Enesuygurs wants to merge 1 commit into
Open
Enesuygurs wants to merge 1 commit into
Enesuygurs wants to merge 1 commit into
Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #2156
The
arrow-reversemarker usesorient="auto-start-reverse", which only flips the arrowhead when it is placed at the start of a path. As a mid or end marker it draws exactly the same thing asarrow, somarkerEnd: "arrow-reverse"looks like it has no effect, yet the TypeScript types accept it formarkerMidandmarkerEnd.As suggested in the issue (and agreed in the comments), this excludes
"arrow-reverse"from themarkerMidandmarkerEndtypes and mentions it in their doc comments.markerandmarkerStartstill accept it, somarker: "arrow-reverse"keeps working for drawing<--->with a single option. This is a types-only change; runtime behavior is unchanged.I added
test/marker.test-d.tswith type tests that checkarrow-reverseis still accepted formarkerandmarkerStartand rejected formarkerMidandmarkerEnd. The test fails on main and passes with this change.pnpm run lint,pnpm run tscand prettier are clean.