Skip to content

Add model to validate the placement block - #87

Merged
ax3l merged 4 commits into
pals-project:mainfrom
woodtp:implement-placement-parameters
Nov 12, 2026
Merged

ax3l merged 4 commits into
pals-project:mainfrom
woodtp:implement-placement-parameters

Conversation

@woodtp

@woodtp woodtp commented Aug 19, 2026 •

Copy link
Copy Markdown
Contributor

Adds a PlacementParameters model according to the standard and incorporates it into the BaseElement.

PlacementParameters defines four fields: offset, to_point, base_item, and from_point. A ValidationError is raised when:

  • offset is not a finite number, such as a string, inf or nan
  • to_point or from_point is not one of ENTRANCE_END, CENTER, EXIT_END, or ZERO_POINT.

I placed the corresponding tests in separate classes to make it easier to run only the tests relevant to these additions.

@EZoni
EZoni requested review from EZoni and ax3l August 24, 2026 15:52

@ax3l ax3l left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot, this LGTM 👍

@ax3l

ax3l commented Nov 12, 2026

Copy link
Copy Markdown
Member

triggering CI

@ax3l ax3l closed this Nov 12, 2026
@ax3l ax3l reopened this Nov 12, 2026
@ax3l ax3l added the element parameters element parameters (properties, attributes) label Nov 12, 2026
@ax3l
ax3l merged commit c934de2 into pals-project:main Nov 12, 2026
16 checks passed
@ax3l ax3l self-assigned this Nov 12, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

element parameters element parameters (properties, attributes)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants