Repository navigation
Backport IR fixes - #25193
Open
ndossche wants to merge 3 commits into
Open
Backport IR fixes#25193ndossche wants to merge 3 commits into
ndossche wants to merge 3 commits into
Conversation
The shared IR_FOLD(AND(AND, _)) / OR / MIN / MAX rule folded (a op b) op a to a instead of a op b, e.g. `$b | ($b | 7)` evaluated to `$b` under the function JIT. Cherry-picks dstogov/ir@6221481
iliaal
approved these changes
Nov 4, 2026
iliaal
left a comment
iliaal
left a comment
Member
There was a problem hiding this comment.
LGTM.
Would you mind backporting dstogov/ir@a38079e as well, it fixes #25037
jorgsowa
approved these changes
Nov 5, 2026
jorgsowa
left a comment
jorgsowa
left a comment
Contributor
There was a problem hiding this comment.
IR update has been merged to master
LamentXU123
approved these changes
Nov 5, 2026
Member
Author
|
@iliaal Yeah I'll cherry-pick, hang on pls |
IR: Backport fix for loop-invariant hoisting across external entries. Mark loops reached from an ENTRY that bypasses their immediate dominator with IR_BB_LOOP_WITH_ENTRY_IN_PREDS, so GCM cannot hoist unbound invariants across those entries. Cherry-picks dstogov/ir@a38079e adapted to the older IR in this branch: the check is placed in the sorted_blocks loop of ir_find_loops(). Fixes phpGH-25037
Member
Author
|
The last backport commit also shows we're starting to run into issues with backporting IR changes. Since the upstream IR source has a slightly different loop due to other changes, I had to port the code. This shows that we're going to have an error-prone process with backporting going forward the more upstream IR starts to diverge from the versions in stable branches. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport IR fold fixes
Fixes GH-24801
Blocked by GH-25180