Repository navigation
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
A named table-level CHECK constraint in a
CREATE TABLEstatement failed to parse:The parser reported "A symbol name was expected! A reserved keyword can not be used as a column name without backquotes" at
CHECKand dropped the constraint (and everything after it) from the parsed statement. This is phpmyadmin/phpmyadmin#20572; the bug lives here because phpMyAdmin delegates parsing to this library. Unnamed table-level CHECK constraints were rejected the same way.Changes
CreateDefinitionsstate 1 now recognises theCHECKkeyword and parses[CONSTRAINT [symbol]] CHECK (expr) [[NOT] ENFORCED]with the existing field options, the same way a column-level CHECK is parsed in state 3.parseCreateTableWithCheckConstraintusing the statement from the original report, registered inCreateStatementTest.Verified locally: the reported statement now parses with no errors and builds back with both constraints; the full test suite passes (1025 tests, 4120 assertions).
Fixes phpmyadmin/phpmyadmin#20572