Skip to content

Preserve authored campaign template-variable CLI policy - #95

Open
purpshell wants to merge 3 commits into
mainfrom
codex/retained-campaign-template-policy-20261029
Open

purpshell wants to merge 3 commits into
mainfrom
codex/retained-campaign-template-policy-20261029

Conversation

@purpshell

@purpshell purpshell commented Oct 28, 2026 •

Copy link
Copy Markdown
Member

Summary

Publish the frozen Campaigns custody candidate e7a17e2b47189f5cf0484e416d53dc85b7a844a0, preserving its original parent, author and source bytes. It adds explicit missing-template-variable launch policy, template mapping display/help and its authored command assertion. No implementation or reconciliation was added in this publication sweep.

Verification

No new tests or review. The retained patch is absent from the accepted 044f launch-command blob, which still equals its original pre-change blob. Its original assertions remain untouched. Current-main integration, generated command reference, browser/source checks and installed/environment qualification are not established for this historical candidate.

Release status

Keep draft; Release owns merge sequencing. API and SDK contract compatibility must be revalidated before integration. CLI source and README change here; package pins are not accepted by this frozen snapshot. Docs/reference adoption, feature availability and package publication remain held. Admin controls are unchanged. No activation, provider acceptance or staging deployment.


View with [code]smith Autofix with [code]smith
Need help on this PR? Tag @codesmith-bot with what you need.

@coderabbitai

coderabbitai Bot commented Oct 28, 2026 •

Copy link
Copy Markdown

Warning

Review limit reached

The included review limit has been reached and this organization has disabled usage-based review continuation. Wait for reviews to reset or ask a billing admin to change After included review limits.

  • Ask an admin to enable usage-based reviews

Open in CodeRabbit

Reviews can continue after your included limit without a manual trigger. An admin must approve usage-based billing.

Next included review available in 28 minutes.

Check out review usage here.

View limit details

Limit details: You’ve used all 2 included reviews currently available. Your 62 included PR review attempts over the past 7 days set your current allowance at 2 reviews per hour.

Learn how review limits work.

Review configuration:

Run configuration

  • Source mode: Auto
  • Repository: Unavailable
  • Branch: Unavailable
  • File: No configuration file from this repository applied
  • Commit: Unavailable
  • Layers: Organization UI
  • Review profile: CHILL
  • Plan: Team
  • Run ID: 871282d1-9236-4fbe-8549-a34e06e8270c
Commits

Reviewing files that changed from the base of the PR and between b7ad48a and cbb7a8e.

Files ignored due to path filters: 1

  • package-lock.json is excluded by !**/package-lock.json
Files selected for processing: 6

  • README.md
  • contracts/cli-reference.json
  • package.json
  • src/commands/campaign/launch.ts
  • src/services/campaigns.ts
  • test/commands/campaigns.test.ts
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

@purpshell
purpshell marked this pull request as ready for review October 31, 2026 04:46
@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Oct 31, 2026 •

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-10-31T04:47:12.267278Z e7a17e2 Draft marked ready
🔒 Security Review ✅ Completed 2026-10-31T04:48:12.644992Z e7a17e2 Draft marked ready
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

…gn-template-policy-20261029

# Conflicts:
#	test/commands/campaigns.test.ts
0.1.0-dev.20261004024706 (the main pin) lacks Campaign.variableMapping
and 0.1.0-dev.20261017182310 drops apiKeys and projectTokens, so pin
0.1.0-dev.20261010020302, the published build that has both. Its
recipient list reason is a closed union without frequency_cap, so the
CLI keeps its own string reason parameter. Refresh the CLI reference.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant