[Roemer]

Updated socat bridge creation to ensure proper socket connection order and background execution.

[Copilot]

🟡 Changes recommended

The entrypoint can execute the requested command without a Docker socket bridge if socat fails, because the polling loop does not verify that the socket appeared.

1 open issue

• Fail startup when the Docker socket bridge is unavailable · New

What changed in this PR

This PR fixes Docker socket bridge startup in the Docker-out feature so socat can handle separate client connections without blocking the container command.

Changes:

• Places the listening socket before the source connection in the socat arguments.
• Runs socat in the background.
• Adds bounded polling for the target socket before continuing.

File	Description
features/​src/​docker-out/​docker-init.sh.tmpl	Corrects socat address order, backgrounds the bridge, and adds socket readiness polling.

_{Review effort: Balanced}

[Copilot]

🔵 Needs a closer look

The socket pathname check can pass before socat starts listening, allowing the command to launch prematurely and encounter ECONNREFUSED.

No open issues 🎉

1 previously missed issue

In code that hasn't changed since last review

Probe socket readiness before launching the command

features/​src/​docker-out/​docker-init.sh.tmpl:84

The socket path exists after bind(), before socat calls listen(), so this check can launch the command while connections still fail with ECONNREFUSED. A bound-but-not-listening UNIX socket passes this loop even though it refuses connections. Replace the pathname checks with a bounded connection-readiness probe against the target socket.

1 resolved since last review

• Fail startup when the Docker socket bridge is unavailable

_{Review effort: Balanced}

[Copilot]

🟡 Changes recommended

Identical socket overrides can cause the script to delete the source socket and create a self-referential listener that recursively spawns socat processes instead of reaching Docker.

1 open issue

• Prevent identical socket overrides from creating a recursive bridge · New

_{Review effort: Balanced}

[Copilot]

🟢 Approval recommended

No active review issues were identified for the Docker-out socket bridge changes.

No open issues 🎉

1 resolved since last review

• Prevent identical socket overrides from creating a recursive bridge

_{Review effort: Balanced}

[eraserix]

lgtm