Repository navigation
Parse midnight in one-based 24-hour clock patterns - #1452
Open
liugedragon wants to merge 1 commit into
Open
liugedragon wants to merge 1 commit into
liugedragon wants to merge 1 commit into
Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
LDML
kandkkpatterns number hours from 1 to 24. Babel already formats midnight as24, butparse_time()passes that value todatetime.time, which rejects it:Normalize hour 24 to 0 when the pattern contains an actual lowercase
kfield. Use the existing pattern tokenizer to distinguish it from uppercaseKand quoted text. This matches the LDML hour-field definition and the existing formatter.Regression coverage checks all 24 hours across four patterns, including reordered fields, plus seven invalid-input controls for other hour cycles, quoted
k, and out-of-range values. This change addresses the midnight value emitted by the formatter and preserves existing lenient parsing behavior for other inputs.Validation on Windows / Python 3.13.4:
git diff --check: passed.