Repository navigation
Update __all__ when renaming exported names - #945
Closed
Narek-Khachikyan wants to merge 1 commit into
Closed
Narek-Khachikyan wants to merge 1 commit into
Narek-Khachikyan wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Renaming an exported name left its old spelling in
__all__, causing star imports to fail. Update matching literal export entries when their module name resolves to the renamed symbol.Fixes #402.
The star-import regression failed with AttributeError before the fix and passes afterward. Python 3.14 validation passed with 2,177 tests. Rename tests passed on Python 3.11 and 3.14, and pre-commit checks passed for the changed files. The Python 3.11 full run has one existing fixture error because its bundled
_sqlite3lacks__file__.Checklist