test_embed: four InitConfigTests tests are always skipped

Bug report

Lines 1113 to 1114 in 069aac9

    
           @unittest.skipIf(support.check_bolt_optimized, "segfaults on BOLT instrumented binaries") 
        
           def test_init_default_config(self):

cpython/Lib/test/test_embed.py

Lines 1201 to 1202 in 069aac9

    
           @unittest.skipIf(support.check_bolt_optimized, "segfaults on BOLT instrumented binaries") 
        
           def test_init_compat_env(self):

cpython/Lib/test/test_embed.py

Lines 1237 to 1238 in 069aac9

    
           @unittest.skipIf(support.check_bolt_optimized, "segfaults on BOLT instrumented binaries") 
        
           def test_init_python_env(self):

cpython/Lib/test/test_embed.py

Lines 1962 to 1963 in 069aac9

    
           @unittest.skipIf(support.check_bolt_optimized, "segfaults on BOLT instrumented binaries") 
        
           def test_initconfig_api(self):

support.check_bolt_optimized is a function:

cpython/Lib/test/support/__init__.py

Lines 1059 to 1065 in 069aac9

    
           def check_bolt_optimized(): 
        
               # Always return false, if the platform is WASI, 
        
               # because BOLT optimization does not support WASM binary. 
        
               if is_wasi: 
        
                   return False 
        
               config_args = sysconfig.get_config_var('CONFIG_ARGS') or '' 
        
               return '--enable-bolt' in config_args

skipIf gets the function itself, which is always true as it defines neither __bool__ nor __len__, so these four tests are skipped on every build since #128474.

CPython versions tested on:

CPython main branch

Operating systems tested on:

Linux

Linked PRs

Good catch. Can you submit a PR? Have you found other, similar cases that could be fixed similarly?

Will do. I did an AST scan for uncalled functions in skipIf/skipUnless, and this is the only one.

Maybe skipIf() and skipUnless() of unittest should raise an assertion error if condition is a function?

Maybe skipIf() and skipUnless() of unittest should raise an assertion error if condition is a function?

I'd rather leave this to a linter than a runtime assert. The latter changes the public API, and may reject code like:

cpython/Lib/test/test__locale.py

Lines 3 to 6 in 7e3290d

    
           try: 
        
               from _locale import (RADIXCHAR, THOUSEP, nl_langinfo) 
        
           except ImportError: 
        
               nl_langinfo = None

cpython/Lib/test/test__locale.py

Line 144 in 7e3290d

@unittest.skipUnless(nl_langinfo, "nl_langinfo is not available")

where the condition is a callable on purpose to check availability.

The latter changes the public API, and may reject code like: (...)

Crap. I should have expected that it's never so easy to change a public API :-(

So well, it's uneasy to have a generic check to detect when skipIf() / skipUnless() is misused.

Recently, I fixed a similar issue with @reap_threads decorator which was used on a test case class, whereas the decorator doesn't support classes. So tests were always skipped: commit 565f76f / PR gh-158937. In that case, I was able to add a check to @reap_threads to detect when it's used on a class.

Merge branch 'main' into pythongh-161270/bolt-skipif

gh-161270: Fix always-skipped `InitConfigTests` in `test_embed` (#161278

[3.14] gh-161270: Fix always-skipped `InitConfigTests` in `test_embed` (

[3.15] gh-161270: Fix always-skipped `InitConfigTests` in `test_embed` (

Navigation Menu

Repository navigation

test_embed: four `InitConfigTests` tests are always skipped #161270

Bug report

CPython versions tested on:

Operating systems tested on:

Linked PRs

Metadata

Assignees

Labels

Projects

Milestone

Relationships

Development

	@unittest.skipIf(support.check_bolt_optimized, "segfaults on BOLT instrumented binaries")
	def test_init_default_config(self):

	@unittest.skipIf(support.check_bolt_optimized, "segfaults on BOLT instrumented binaries")
	def test_init_compat_env(self):

	@unittest.skipIf(support.check_bolt_optimized, "segfaults on BOLT instrumented binaries")
	def test_init_python_env(self):

	@unittest.skipIf(support.check_bolt_optimized, "segfaults on BOLT instrumented binaries")
	def test_initconfig_api(self):

	def check_bolt_optimized():
	# Always return false, if the platform is WASI,
	# because BOLT optimization does not support WASM binary.
	if is_wasi:
	return False
	config_args = sysconfig.get_config_var('CONFIG_ARGS') or ''
	return '--enable-bolt' in config_args

	try:
	from _locale import (RADIXCHAR, THOUSEP, nl_langinfo)
	except ImportError:
	nl_langinfo = None

test_embed: four InitConfigTests tests are always skipped #161270

Description

Bug report

CPython versions tested on:

Operating systems tested on:

Linked PRs

Activity

gvanrossum commented on Nov 3, 2026

NekoAsakura commented on Nov 3, 2026

vstinner commented on Nov 3, 2026

NekoAsakura commented on Nov 3, 2026

vstinner commented on Nov 4, 2026

Metadata

Metadata

Assignees

Labels

Projects

Milestone

Relationships

Development

Issue actions

test_embed: four `InitConfigTests` tests are always skipped #161270