Skip to content

Fix set hw param failure - #1484

Open
Mohis-12 wants to merge 2 commits into
qualcomm-linux:qcom-6.18.yfrom
Mohis-12:fix-set-hw-param-failure
Open

Mohis-12 wants to merge 2 commits into
qualcomm-linux:qcom-6.18.yfrom
Mohis-12:fix-set-hw-param-failure

Conversation

@Mohis-12

@Mohis-12 Mohis-12 commented Nov 19, 2026 •

Copy link
Copy Markdown

This PR reverts the earlier FROMLIST Audio IF patch, which omitted a required break and caused media-format setup to fall through into shared-memory endpoint handling. It then applies the corrected upstream implementation as a FROMGIT commit
CRs Fixed: 4743039

@qswat-orbit-external

Copy link
Copy Markdown

Merge Check Failed: No CR Numbers Found

Error: No Change Request numbers were found.

Please add Change Request numbers to your pull request description in the format CRs-Fixed: 12345 or link GitHub issues that are associated with Change Requests.

2 similar comments
@qswat-orbit-external

Copy link
Copy Markdown

Merge Check Failed: No CR Numbers Found

Error: No Change Request numbers were found.

Please add Change Request numbers to your pull request description in the format CRs-Fixed: 12345 or link GitHub issues that are associated with Change Requests.

@qswat-orbit-external

Copy link
Copy Markdown

Merge Check Failed: No CR Numbers Found

Error: No Change Request numbers were found.

Please add Change Request numbers to your pull request description in the format CRs-Fixed: 12345 or link GitHub issues that are associated with Change Requests.

The earlier FROMLIST version omitted a break after handling the Audio
IF source and sink modules. This caused the switch to fall through to
the shared-memory endpoint setup.

Revert it before applying the corrected upstream version.

This reverts commit 905332e.

Signed-off-by: Mohit Sharma <mohis@qti.qualcomm.com>
@Mohis-12
Mohis-12 force-pushed the fix-set-hw-param-failure branch from c5bcc40 to 2189b33 Compare November 19, 2026 08:18
@qswat-orbit-external

Copy link
Copy Markdown

Merge Check Failed: No CR Numbers Found

Error: No Change Request numbers were found.

Please add Change Request numbers to your pull request description in the format CRs-Fixed: 12345 or link GitHub issues that are associated with Change Requests.

Add topology parsing and media-format programming for Audio IF source
and sink modules.

Add the Audio IF module IDs and required topology tokens. Add a
dedicated topology loader that stores the parsed interface
configuration in the AudioReach module state. Add the Audio IF
media-format path that sends the interface configuration, hardware
endpoint media format, and frame duration parameters for Audio IF
modules.

This keeps the serial-interface configuration topology-driven while
allowing the machine driver to provide runtime slot and media-format
settings. The same Audio IF path can be reused for TDM, PCM, and I2S
style backends.

The new UAPI tokens range from AR_TKN_U16_MODULE_SYNC_SRC at 262
through AR_TKN_U8_MODULE_INV_EXT_BIT_CLK at 276. Value defines are
also added for sync source, sync mode, data delay, interface mode,
bit-clock type, and polarity tokens.

MODULE_ID_AUDIO_IF_SINK (0x0700117C) and MODULE_ID_AUDIO_IF_SOURCE
(0x0700117D) are introduced in this patch.

This module is validated on Hawi and Shikra platforms.

Signed-off-by: Prasad Kumpatla <prasad.kumpatla@oss.qualcomm.com>
Link: https://patch.msgid.link/20260804070307.117119-2-prasad.kumpatla@oss.qualcomm.com
Signed-off-by: Mark Brown <broonie@kernel.org>
@Mohis-12
Mohis-12 force-pushed the fix-set-hw-param-failure branch from 2189b33 to b346fe4 Compare November 19, 2026 12:17
@qswat-orbit-external

Copy link
Copy Markdown

Merge Check Failed: No CR Numbers Found

Error: No Change Request numbers were found.

Please add Change Request numbers to your pull request description in the format CRs-Fixed: 12345 or link GitHub issues that are associated with Change Requests.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants