Skip to content

FROMLIST: PCI/pwrctrl: tc9563: Enable 8 GT/s equalization fine-tuning - #1490

Open
abhi6246-OSS wants to merge 1 commit into
qualcomm-linux:qcom-6.18.yfrom
abhi6246-OSS:tc9563-eq-fine-tuning-6.18
Open

abhi6246-OSS wants to merge 1 commit into
qualcomm-linux:qcom-6.18.yfrom
abhi6246-OSS:tc9563-eq-fine-tuning-6.18

Conversation

@abhi6246-OSS

@abhi6246-OSS abhi6246-OSS commented Nov 19, 2026 •

Copy link
Copy Markdown

On some boots, links on the PCIe switch report a continuous flood of correctable AER errors (RxErr, BadTLP and Replay Timer Timeout) at 8 GT/s. This happens because the 8 GT/s equalization fine-tuning setting is never programmed: max_num_of_fine_tuning_iterations_at_8gt in K_EQUTUNING_033_028 resets to 0, so equalization only selects a preset and never fine-tunes the transmitter coefficients for the channel, leaving the link with marginal signal quality.

Fix this by programming one fine-tuning iteration on the upstream port and downstream ports 1 and 2 at power-on, so that 8 GT/s equalization adapts the transmitter coefficients to the channel. With this setting the links no longer report any AER errors.

CRs-Fixed: 4742658

@qswat-orbit-external

Copy link
Copy Markdown

Merge Check Failed: No CR Numbers Found

Error: No Change Request numbers were found.

Please add Change Request numbers to your pull request description in the format CRs-Fixed: 12345 or link GitHub issues that are associated with Change Requests.

3 similar comments
@qswat-orbit-external

Copy link
Copy Markdown

Merge Check Failed: No CR Numbers Found

Error: No Change Request numbers were found.

Please add Change Request numbers to your pull request description in the format CRs-Fixed: 12345 or link GitHub issues that are associated with Change Requests.

@qswat-orbit-external

Copy link
Copy Markdown

Merge Check Failed: No CR Numbers Found

Error: No Change Request numbers were found.

Please add Change Request numbers to your pull request description in the format CRs-Fixed: 12345 or link GitHub issues that are associated with Change Requests.

@qswat-orbit-external

Copy link
Copy Markdown

Merge Check Failed: No CR Numbers Found

Error: No Change Request numbers were found.

Please add Change Request numbers to your pull request description in the format CRs-Fixed: 12345 or link GitHub issues that are associated with Change Requests.

@abhi6246-OSS
abhi6246-OSS force-pushed the tc9563-eq-fine-tuning-6.18 branch from 47354cd to b3127fd Compare November 19, 2026 11:57
@qswat-orbit-external

Copy link
Copy Markdown

Merge Check Failed: No CR Numbers Found

Error: No Change Request numbers were found.

Please add Change Request numbers to your pull request description in the format CRs-Fixed: 12345 or link GitHub issues that are associated with Change Requests.

@abhi6246-OSS
abhi6246-OSS force-pushed the tc9563-eq-fine-tuning-6.18 branch from b3127fd to e58b1ed Compare November 19, 2026 11:58
@qswat-orbit-external

Copy link
Copy Markdown

Merge Check Failed: No CR Numbers Found

Error: No Change Request numbers were found.

Please add Change Request numbers to your pull request description in the format CRs-Fixed: 12345 or link GitHub issues that are associated with Change Requests.

On some boots, links on the PCIe switch report a continuous flood of
correctable AER errors (RxErr, BadTLP and Replay Timer Timeout) at
8 GT/s. This happens because the 8 GT/s equalization fine-tuning
setting is never programmed: max_num_of_fine_tuning_iterations_at_8gt
in K_EQUTUNING_033_028 resets to 0, so equalization only selects a
preset and never fine-tunes the transmitter coefficients for the
channel, leaving the link with marginal signal quality.

Fix this by programming one fine-tuning iteration on the upstream port
and downstream ports 1 and 2 at power-on, so that 8 GT/s equalization
adapts the transmitter coefficients to the channel. With this setting
the links no longer report any AER errors.

Link: https://lore.kernel.org/linux-pci/20261119-tc9563_fine_tune-v1-1-b83c74bf1e94@oss.qualcomm.com/
Signed-off-by: Abhishek Kumar <abhishek.kumar15@oss.qualcomm.com>
@abhi6246-OSS
abhi6246-OSS force-pushed the tc9563-eq-fine-tuning-6.18 branch from e58b1ed to ecedc5c Compare November 19, 2026 11:59
@qswat-orbit-external

Copy link
Copy Markdown

Merge Check Failed: No CR Numbers Found

Error: No Change Request numbers were found.

Please add Change Request numbers to your pull request description in the format CRs-Fixed: 12345 or link GitHub issues that are associated with Change Requests.

@qswat-orbit-external

Copy link
Copy Markdown

Merge Check Failed: No Change Task Found

No associated change tasks found for CR 4742658 on any of the following entities:

Entities:

  • kernel.qli.2.0

CR: 4742658

Please ensure the CR has a change task associated with at least one of the entities for this branch.

1 similar comment
@qswat-orbit-external

Copy link
Copy Markdown

Merge Check Failed: No Change Task Found

No associated change tasks found for CR 4742658 on any of the following entities:

Entities:

  • kernel.qli.2.0

CR: 4742658

Please ensure the CR has a change task associated with at least one of the entities for this branch.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant