Skip to content

Fix Q6DSP_MAX_CLK_ID out of bound issue - #1491

Open
mohsRafi wants to merge 3 commits into
qualcomm-linux:qcom-6.18.yfrom
mohsRafi:Fix_qdsp6_clk_out_of_bond
Open

mohsRafi wants to merge 3 commits into
qualcomm-linux:qcom-6.18.yfrom
mohsRafi:Fix_qdsp6_clk_out_of_bond

Conversation

@mohsRafi

@mohsRafi mohsRafi commented Nov 19, 2026 •

Copy link
Copy Markdown
Contributor

Backport missing Q6DSP_MAX_CLK_ID update. Boot issue seen in kodiak and monaco

CRs-Fixed: 4751464

error log:

[2026-11-17 06:56:29.426] [ 14.024936] Unable to handle kernel execute from non-executable memory at virtual address ffff00008e3a9a00
[2026-11-17 06:56:29.426] [ 14.034947] Mem abort info:
[2026-11-17 06:56:29.426] [ 14.037840] ESR = 0x000000008600000f
[2026-11-17 06:56:29.426] [ 14.041723] EC = 0x21: IABT (current EL), IL = 32 bits
[2026-11-17 06:56:29.426] [ 14.047199] SET = 0, FnV = 0
[2026-11-17 06:56:29.426] [ 14.050344] EA = 0, S1PTW = 0
[2026-11-17 06:56:29.426] [ 14.053587] FSC = 0x0f: level 3 permission fault
[2026-11-17 06:56:29.426] [ 14.058522] swapper pgtable: 4k pages, 48-bit VAs, pgdp=00000001ee5a7000
[2026-11-17 06:56:29.426] [ 14.065418] [ffff00008e3a9a00] pgd=0000000000000000, p4d=18000001fffff403, pud=18000001ffd21403, pmd=18000001ffcaf403, pte=00e800010e3a9f07
[2026-11-17 06:56:29.480] [ 14.078294] Internal error: Oops: 000000008600000f [#1] SMP
[2026-11-17 06:56:29.480] [ 14.084109] Modules linked in: ucsi_glink typec_ucsi qcom_battmgr pwrseq_qcom_wcn usb_conn_gpio nvmem_reboot_mode fastrpc qmi_cooling msm_kgsl(O) socinfo msm ubwc_config llcc_qcom ocmem audioreach_driver(O) qcom_camss gpu_sched drm_gpuvm snd_q6dsp_common lontium_lt9611uxc(+) drm_exec pmic_glink_altmode imx412 drm_display_helper videobuf2_dma_sg aux_hpd_bridge nb7vpq904m apr cec videobuf2_memops v4l2_fwnode phy_qcom_qmp_combo dispcc_sc7280 videobuf2_v4l2 pmic_glink drm_dp_aux_bus v4l2_async drm_client_lib display_connector aux_bridge pdr_interface gpucc_sc7280 typec videodev phy_qcom_edp drm_kms_helper videobuf2_common camcc_sc7280 i2c_qcom_cci snd_soc_wsa883x mc snd_soc_lpass_va_macro snd_soc_lpass_wsa_macro qcom_q6v5_pas snd_soc_dmic soundwire_qcom snd_soc_hdmi_codec snd_soc_lpass_macro_common regmap_sdw qcom_pil_info snd_soc_core qcom_q6v5 soundwire_bus snd_compress qcom_sysmon snd_pcm qcom_common pinctrl_sc7280_lpass_lpi qcom_pd_mapper qrtr_smd qcom_glink_smem snd_timer snd slimbus rpmsg_ctrl mdt_loader
[2026-11-17 06:56:29.530] [ 14.084313] qcom_pdr_msg pinctrl_lpass_lpi lpassaudiocc_sc7280 soundcore qrtr rpmsg_char qmi_helpers fuse drm backlight nfnetlink
[2026-11-17 06:56:29.580] [ 14.187711] CPU: 2 UID: 0 PID: 84 Comm: kworker/u32:6 Tainted: G O 6.18.56-g9bdb1505d1f8-p1 #1 PREEMPT
[2026-11-17 06:56:29.580] [ 14.198872] Tainted: [O]=OOT_MODULE
[2026-11-17 06:56:29.580] [ 14.202459] Hardware name: Qualcomm Technologies, Inc. Robotics RB3gen2 (DT)
[2026-11-17 06:56:29.580] [ 14.209697] Workqueue: events_unbound deferred_probe_work_func
[2026-11-17 06:56:29.580] [ 14.215701] pstate: 60400009 (nZCv daif +PAN -UAO -TCO -DIT -SSBS BTYPE=--)
[2026-11-17 06:56:29.580] [ 14.222851] pc : 0xffff00008e3a9a00
[2026-11-17 06:56:29.580] [ 14.226451] lr : clk_vote_q6dsp_block+0x4c/0x68 [snd_q6dsp_common]
[2026-11-17 06:56:29.631] [ 14.232813] sp : ffff8000809bb780
[2026-11-17 06:56:29.631] [ 14.236222] x29: ffff8000809bb780 x28: ffffab6478735080 x27: ffffab64783d47ef
[2026-11-17 06:56:29.631] [ 14.243557] x26: 0000000000000001 x25: ffffab64772dae88 x24: ffff000090ab4de0
[2026-11-17 06:56:29.631] [ 14.250893] x23: ffff000090ab4db0 x22: 0000000000000001 x21: ffff00008e3a9a00
[2026-11-17 06:56:29.631] [ 14.258225] x20: ffff000094a0cc10 x19: ffff0000949dee18 x18: 000000000000000a
[2026-11-17 06:56:29.631] [ 14.265559] x17: 74616c756765723a x16: ffffab6476732478 x15: 0000000000000000
[2026-11-17 06:56:29.631] [ 14.272890] x14: 00000000ffffffff x13: 00000000ffff0a01 x12: 00000000ffffffff
[2026-11-17 06:56:29.682] [ 14.280222] x11: ffff00008ec9f908 x10: 0000000000068c80 x9 : ffffab641913a540
[2026-11-17 06:56:29.682] [ 14.287556] x8 : 0101010101010101 x7 : 00000000000000bc x6 : 0911040aadf2e5f3
[2026-11-17 06:56:29.682] [ 14.294888] x5 : 00000000000000bc x4 : ffff0000813f8000 x3 : ffff0000949dee14
[2026-11-17 06:56:29.682] [ 14.302219] x2 : ffff00008dd44240 x1 : 0000000000000001 x0 : ffff000094a0cc10
[2026-11-17 06:56:29.682] [ 14.309552] Call trace:
[2026-11-17 06:56:29.682] [ 14.312081] 0xffff00008e3a9a00 (P)
[2026-11-17 06:56:29.682] [ 14.315669] clk_core_prepare+0x90/0x2a8
[2026-11-17 06:56:29.682] [ 14.319712] clk_prepare+0x2c/0x58
[2026-11-17 06:56:29.682] [ 14.323216] pm_clk_resume+0x108/0x1a0
[2026-11-17 06:56:29.732] [ 14.327078] lpi_pinctrl_runtime_resume+0x18/0x30 [pinctrl_lpass_lpi]
[2026-11-17 06:56:29.732] [ 14.333708] pm_generic_runtime_resume+0x34/0x60
[2026-11-17 06:56:29.732] [ 14.338464] __rpm_callback+0x50/0x220
[2026-11-17 06:56:29.732] [ 14.342328] rpm_callback+0x7c/0x90
[2026-11-17 06:56:29.732] [ OK ] Finished Rebuild Dynamic Linker Cac[ 14.345924] rpm_resume+0x448/0x650

…ote clock

Q6DSP_MAX_CLK_ID defines the upper bound of supported clock
identifiers in the qdsp6 LPASS clock driver.

Increase the maximum clock ID value to accommodate the LPASS
LPR vote clock identifier.

Signed-off-by: Prasad Kumpatla <prasad.kumpatla@oss.qualcomm.com>
Acked-by: Bartosz Golaszewski <bartosz.golaszewski@oss.qualcomm.com>
Reviewed-by: Srinivas Kandagatla <srinivas.kandagatla@oss.qualcomm.com>
Link: https://patch.msgid.link/20260724141708.2212057-3-prasad.kumpatla@oss.qualcomm.com
Signed-off-by: Mark Brown <broonie@kernel.org>
Q6AFE_MAX_CLK_ID is not used anywhere. Remove the unused define.

Signed-off-by: Prasad Kumpatla <prasad.kumpatla@oss.qualcomm.com>
Reviewed-by: Dmitry Baryshkov <dmitry.baryshkov@oss.qualcomm.com>
Link: https://patch.msgid.link/20260722111655.3558096-1-prasad.kumpatla@oss.qualcomm.com
Signed-off-by: Mark Brown <broonie@kernel.org>
@qswat-orbit-external

Copy link
Copy Markdown

Merge Check Failed: No CR Numbers Found

Error: No Change Request numbers were found.

Please add Change Request numbers to your pull request description in the format CRs-Fixed: 12345 or link GitHub issues that are associated with Change Requests.

3 similar comments
@qswat-orbit-external

Copy link
Copy Markdown

Merge Check Failed: No CR Numbers Found

Error: No Change Request numbers were found.

Please add Change Request numbers to your pull request description in the format CRs-Fixed: 12345 or link GitHub issues that are associated with Change Requests.

@qswat-orbit-external

Copy link
Copy Markdown

Merge Check Failed: No CR Numbers Found

Error: No Change Request numbers were found.

Please add Change Request numbers to your pull request description in the format CRs-Fixed: 12345 or link GitHub issues that are associated with Change Requests.

@qswat-orbit-external

Copy link
Copy Markdown

Merge Check Failed: No CR Numbers Found

Error: No Change Request numbers were found.

Please add Change Request numbers to your pull request description in the format CRs-Fixed: 12345 or link GitHub issues that are associated with Change Requests.

@mohsRafi
mohsRafi force-pushed the Fix_qdsp6_clk_out_of_bond branch from 2b80790 to 56a1405 Compare November 19, 2026 12:42
@qswat-orbit-external

Copy link
Copy Markdown

Merge Check Failed: No CR Numbers Found

Error: No Change Request numbers were found.

Please add Change Request numbers to your pull request description in the format CRs-Fixed: 12345 or link GitHub issues that are associated with Change Requests.

Add a new clock ID, LPASS_HW_LPR_VOTE, to represent the LPASS low-power
resource (LPR) vote through the PRM interface.

The LPASS PRM supports a resource voting mechanism to control low-power
states via PARAM_ID_RSC_CPU_LPR. Exposing this as a q6prm clock ID allows
clients to request the LPR vote using the existing qcom,q6prm clock
provider interface.

This functionality is required on newer platforms (e.g. Hawi) where LPASS
clients need to explicitly manage LPR resource voting via PRM.

Acked-by: Krzysztof Kozlowski <krzysztof.kozlowski@oss.qualcomm.com>
Signed-off-by: Prasad Kumpatla <prasad.kumpatla@oss.qualcomm.com>
Acked-by: Bartosz Golaszewski <bartosz.golaszewski@oss.qualcomm.com>
Link: https://patch.msgid.link/20260724141708.2212057-2-prasad.kumpatla@oss.qualcomm.com
Signed-off-by: Mark Brown <broonie@kernel.org>
@mohsRafi
mohsRafi force-pushed the Fix_qdsp6_clk_out_of_bond branch from 56a1405 to 5b477a5 Compare November 19, 2026 12:43
@qswat-orbit-external

Copy link
Copy Markdown

Merge Check Failed: No CR Numbers Found

Error: No Change Request numbers were found.

Please add Change Request numbers to your pull request description in the format CRs-Fixed: 12345 or link GitHub issues that are associated with Change Requests.

@qswat-orbit-external

Copy link
Copy Markdown

Merge Check Failed: CR Not Eligible for Merge

CR 4751464 is not eligible for merge.

The parent software image for kernel.qli.2.0 is not development complete.

Entity: kernel.qli.2.0
CR: 4751464
Reason: CR_CANNOT_MERGE

Please ensure the CR passes both CCT (ComponentChangeTasks) and ICT (Integration Change Tasks) validations.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants