Repository navigation
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview
React Native 0.88 can build apps with Swift Package Manager. React Native 0.89 plans to make it the default. This library has no
Package.swift, so SwiftPM apps cannot use it.Package.swiftwith separate Swift and Objective-C++ targets.swiftpmConfig.nameand ship the package support files through npm.Under SwiftPM, the Objective-C++ code cannot import Xcode's generated Swift header.
spm-headers/react_native_menu-Swift.hdeclares the needed Swift API by hand.spm-support/SwiftHeaderPin.swiftmakes the SwiftPM build fail if the checked Swift API changes. Both files must be updated together.MenuView.hstays private and is not exposed to other packages.CocoaPods is unchanged. The podspec and
ios/sources are untouched.Limits: iOS 15.1 and later. The pin cannot check Objective-C class or member name strings. No CI job here builds the Swift package yet.
Closes #1231.
RFC: react-native-community/discussions-and-proposals#994
Test Plan
How I tested
In a new React Native 0.88.1 app, with the library installed from the local checkout:
Add and update passed. Debug and Release ended with
** BUILD SUCCEEDED **.Changing
onOpenMenuto returnBoolin the protocol and both implementations built with the pin removed, then failed in the restored pin. Restoring the API built successfully.Runtime check: the simulator menu opened with two actions. Selecting First action returned
firstand showedselected action: first.