Repository navigation
docs(ios): document Swift Package Manager support - #920
Merged
Merged
Conversation
Add the changelog entry for #919, a Swift Package Manager section to the iOS installation docs with a pointer from the README, require Package.swift and the public header in the npm package check, and ignore the .build and .swiftpm folders that SwiftPM tools create at the repo root.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #919, which added Swift Package Manager support.
CHANGELOG.md: the entry for feat(ios): add Swift Package Manager support #919 under[Unreleased].docs/ios-installation.md: a Swift Package Manager section, linked from the README's installation section.scripts/check-package.js:Package.swiftandinclude/RNCallKeep/RNCallKeep.hare now required in the npm package, so a later.npmignorechange cannot drop them unnoticed..gitignore:.build/and.swiftpm/, whichswift packageand Xcode create next to the rootPackage.swift.Test plan
npm run checkpasses; the new#swift-package-managerlinks resolve.npx react-native spm add --deintegrate --yesmoves a CocoaPods app to SwiftPM, and in that appnpx react-native spmruns an update that uses CallKeep'sPackage.swift. Debug and Release builds succeed, and on the iOS simulator a Swift scene delegate callsRNCallKeepafterimport RNCallKeep, without a bridging header.