Repository navigation
Fix broken examples and code highlighting in ViewTransition and addTransitionType - #8737
Open
BlackHatMan wants to merge 1 commit into
Open
BlackHatMan wants to merge 1 commit into
BlackHatMan wants to merge 1 commit into
Conversation
…ansitionType
The fixed example in "two <ViewTransition name=%s> components" still
passes item={item} while Item reads {id}, so every item is named
"item-undefined" and triggers the same error. The first addTransitionType
example has a syntax error ({action)) and a fence without a language, so
its CodeSteps never render.
Line highlights written as [3, 5] / [3] / [11] are ignored by
getHighlightLines, which only reads {...}; switch them to braces and
update ranges that no longer match the code.
Also use checked instead of value on the "Fast" checkbox, move key to
the outer element in the wrapper snippet, drop the nonexistent `layout`
prop from addTransitionType, and remove a "sidebar" reference from the
Activity example, which only has a counter.
Size changesDetails📦 Next.js Bundle Analysis for react-devThis analysis was generated by the Next.js Bundle Analysis action. 🤖 This PR introduced no changes to the JavaScript bundle! 🙌 |
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Examples that don't work as written
ViewTransition→ Troubleshooting → "two<ViewTransition name=%s>components": the fixed example destructuresidinItem, butItemListpassesitem={item}, so every item still getsname="item-undefined"and triggers the same error. Now passesid={item.id}.addTransitionType→ Usage:function Submit({action) {is a syntax error.ViewTransition: the "Fast" checkbox usedvalue={isFast}, which doesn't control a checkbox; changed tochecked.ViewTransition: in the wrapper-element snippet,keywas on the inner<Component>instead of the element returned frommap.Highlighting that doesn't render
[3, 5]/[3]/[11]for line highlights.getHighlightLinesinCodeBlock.tsxonly matches{...}, so nothing was highlighted. Switched to braces.<div>above<ViewTransition>" Pitfall, the example was rewritten in [ViewTransition] Add docs for using with Activity #8320 and line 5 is now<Video>; the range is{3,7}(the<div>open/close), matching the similar Troubleshooting example.addTransitionType,[11]pointed atsetShow(true); it now highlightsaddTransitionType(...)(line 10), which the section is about.addTransitionTypeexample had no language on the fence, so the[[...]]metadata was parsed as the language and the three CodeSteps referenced in the next paragraph never rendered. Step 2 was also missing its closing].Text
addTransitionType:<ViewTransition>has nolayoutprop.ViewTransition→ "Animating enter/exit with Activity": the text referred to a "sidebar", but the sandbox only renders aCounter.Test plan
/reference/react/ViewTransitionhighlighted lines 3 → 11;/reference/react/addTransitionTypeinline CodeSteps 0 → 3, highlighted lines 0 → 1.