Repository navigation
ci: bump upload-pages-artifact to v4.0.0 to fix Pages deploy under M14 - #278
Merged
Merged
Conversation
ben-harris-5
approved these changes
Nov 10, 2026
RGood
added a commit
that referenced
this pull request
Nov 10, 2026
…t) (#279) ## Why After #278 (bump `upload-pages-artifact` to v4.0.0), the Pages deploy hangs: `deploy-pages` polls "Getting Pages deployment status" with an empty status for 10 minutes, then times out and cancels. This happened twice on `de8c0dc`: - https://github.com/reddit/devvit-docs/actions/runs/42881767862 The build and artifact upload succeed (157 MB, same size as before), and githubstatus shows Pages/Actions operational. Every successful deploy used the v3 artifact; both hung deploys used the v4.0.0 artifact. This PR is an **A/B test** to see whether the artifact version is the cause. ## Change Revert only `actions/upload-pages-artifact` to the previously used v3.0.1 (`56afc60…`), keeping the SHA pin and version comment. `devvit-docs` is now exempt from the "require full SHA" setting, and v3 only calls GitHub-owned `actions/upload-artifact@v4`, which is allowed. ## What to check after merge The "Deploy to GitHub Pages" run on `main` should finish in roughly 3-4 minutes (previous successes: 184-480s). - **Succeeds:** v4.0.0 (or the nested change) is the cause. Next try v5.0.0 (`fc324d3…`) or investigate the artifact. - **Still hangs:** the artifact version isn't the cause; look at Pages service/site size (157 MB) and try a longer `timeout` on `deploy-pages`. ## Notes - This workflow only runs on push to `main`, so it cannot be verified on the PR itself. - Temporary. If v3 works, decide whether to keep it, move to v5, or re-enable SHA pinning with a different fix.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Since the M14 settings change (SHA pinning required, GitHub-owned actions only), every push to
mainfails the "Deploy to GitHub Pages" workflow:actions/upload-pages-artifactv3 is pinned indeploy.yml, but the action internally callsactions/upload-artifact@v4(an unpinned tag). The SHA-pinning requirement applies to those nested references too. Failing runs: https://github.com/reddit/devvit-docs/actions/runs/42880123163Fix
Bump
actions/upload-pages-artifactfrom v3 (56afc60…) to v4.0.0 (7b1f4a7…), whose internalupload-artifactis pinned to a full SHA (v4.6.2). Same pinned-SHA convention with a version comment.Notes
static/, so the site output is unaffected.actions/deploy-pagesstays on the pinned v4 and is compatible.Testing
This workflow runs only on push to
main, so it can't be verified on the PR. After merge, confirm the "Deploy to GitHub Pages" run onmainsucceeds. Thebuildcheck on this PR covers the docs build itself.