Skip to content

chore(security): override undici to 6.29.1 (RQ-9393 follow-up) - #121

Merged
wrongsahil merged 1 commit into
masterfrom
rq-9393/undici-override
Nov 16, 2026
Merged

wrongsahil merged 1 commit into
masterfrom
rq-9393/undici-override

Conversation

@wrongsahil

@wrongsahil wrongsahil commented Nov 16, 2026 •

Copy link
Copy Markdown
Member

Why

#120 upgraded release-it to 19.2.4 so that engine-strict works on Node 24. That version pins undici to exactly 6.23.0, which is vulnerable. When #120 merged, 14 undici Dependabot alerts (4 High) opened in this repo. This PR fixes that regression.

What

overrides: { "undici": "6.29.1" }: the patched release in the same major as release-it's pin, published more than 14 days ago.

Why an override and not a release-it bump:

  • release-it 20.x pins undici 7.24.5, which is also vulnerable.
  • 21.x pins a fixed 7.30.1, but needs Node ^22.22.2 and a changelog-plugin major upgrade.

undici here is only used by the dev release tooling; runtime packages are unchanged vs master.

Verified locally

Check Node 22.22.0 Node 24.22.1 (CI)
npm ci (with .npmrc) ✅ ✅
npm run build (tsc) ✅ ✅
dist/ vs master byte-identical (96 files) byte-identical
every require() in dist/ resolves ✅ ✅
release dry-run (CI release command) ✅ ✅

npm audit High/Critical, by root advisory: undici is removed and nothing is added. The remaining roots (axios, form-data, lodash, node-forge, ws, picomatch, basic-ftp) were all there before and are tracked separately (runtime: RQ-9394).

🤖 Generated with Claude Code

Summary by CodeRabbit

  • Release Notes
    • No user-facing changes are included in this update. The app’s visible behavior and available features remain unchanged. There are no new capabilities, fixes, or interface updates to call out.

release-it 19.2.4 pins undici to exactly 6.23.0, which opened 14 undici
Dependabot alerts (4 High) once #120 merged. Force the patched 6.29.1:
same major, published >14 days ago. release-it 20.x pins undici 7.24.5
(also vulnerable) and 21.x needs Node ^22.22.2, so an override is the
smallest fix.

npm audit high/critical by root advisory, before -> after: undici removed,
nothing added. Runtime packages unchanged vs master.

Verified on Node 22 and 24: npm ci, build, dist/ byte-identical to master,
all dist require() calls resolve, release dry-run.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@coderabbitai

coderabbitai Bot commented Nov 16, 2026 •

Copy link
Copy Markdown

Explain Change →

No actionable comments were generated in the recent review.

Walkthrough

package.json adds an npm override that pins undici to version 6.29.1.

Changes: Dependency override

Layer / File(s) Summary
Pin the undici version
package.json
An npm override pins undici to 6.29.1.

Estimated code review effort: 2 (Simple) | ~5 minutes

Change: Other

Suggested reviewers: nsrcodes, sagarsoni7

Merge Risk: Minimal · up to e8de8

This change pins a development-only release tool dependency to a patched version to clear security alerts. Runtime packages are unaffected, and there is no known merge-blocking risk.

Pre-merge checks: Passed 4

Check name Status Explanation
Description Check Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check Passed The title names the main change: an npm override that pins undici to 6.29.1 in package.json, which the raw summary and objectives both describe. The '(RQ-9393 follow-up)' tag and the 'chore(security)'…
Linked Issues check Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check Passed Check skipped because no linked issues were found for this pull request.
Full details: Title check

Explanation

The title names the main change: an npm override that pins undici to 6.29.1 in package.json, which the raw summary and objectives both describe. The '(RQ-9393 follow-up)' tag and the 'chore(security)' prefix are accurate context for a security-driven dependency change. The title is specific and concise, and a teammate scanning history would understand the primary change.

Finishing Touches

Generate unit tests (beta)

  • Commit to this branch
  • Create a new PR
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

A rabbit checks the package list,
One version gets a steady pin.
undici rests at 6.29.1,
The burrow hums with tidy code.
I hop along, pleased with the change!

Recent review info

Run configuration

Commits

Reviewing files that changed from the base of the PR and between c5728a1 and e8de85c.

Files ignored due to path filters: 1

  • package-lock.json is excluded by !**/package-lock.json
Files selected for processing: 1

  • package.json

Included review availability: This review used your included allowance. Your plan provides up to 12 included reviews per hour; 3 remain after this review.

@pkg-pr-new

pkg-pr-new Bot commented Nov 16, 2026

Copy link
Copy Markdown

Open in StackBlitz

npm i https://pkg.pr.new/@requestly/requestly-proxy@121

commit: e8de85c

@wrongsahil
wrongsahil merged commit f644f02 into master Nov 16, 2026
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant