Repository navigation
docs(webapi): update alpha guides and fix broken links [Codex] - #398
Conversation
Independent review —
|
Independent re-review —
|
Independent final review —
|
Independent follow-up review —
|
Independent final supplemental review summary —
|
|
Author verification summary for #393–#395 (this is an implementation/validation report, not a formal review approval or request to land):
Local validation on Node 24.16.0 / npm 11.15.0: fresh GitHub checks on this exact head: |
Codex Review Summary: ✅ CompletedThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
Supplemental independent review — final
|
|
Final author verification update for PR #398 at head
Final local validation: GitHub CI on this head: |
|
Final stack synchronization for PR #398: the base now points to GitHub |
Fixes bindings that compiled but called the wrong browser method or used the wrong types. This covers WebSocket and worker calls, observer callbacks, and DOM, audio and crypto APIs. Byte readers are now typed as `Uint8Array` rather than plain arrays. HTTP body streams must yield `Uint8Array` chunks. Browser tests and compiler checks cover the corrected behavior. Builds on #397. Some public types change; #398 provides the migration notes and remaining documentation. Fixes #386. Fixes #389. Refs #383, #387, #388, #390, #391 and #392.
Fixes bindings that compiled but called the wrong browser method or used the wrong types. This covers WebSocket and worker calls, observer callbacks, and DOM, audio and crypto APIs. Byte readers are now typed as `Uint8Array` rather than plain arrays. HTTP body streams must yield `Uint8Array` chunks. Browser tests and compiler checks cover the corrected behavior. Builds on #397. Some public types change; #398 provides the migration notes and remaining documentation. Fixes #386. Fixes #389. Refs #383, #387, #388, #390, #391 and #392.
fd007c8 to
7d92df2
Compare
Makes the package installable with ReScript 13 alpha and checks the npm package that consumers will actually install. Improves the test runner, adds browser tests, and updates vulnerable development dependencies. Alpha releases use numbered versions and are checked before publishing. Pull request checks do not receive publishing permissions. This is the base for #399 and #398. A maintainer still needs to verify npm Trusted Publishing before publishing the v1 alpha (#385). Closes #384. Closes #396. Refs #383 and #385.
7d92df2 to
fa4931f
Compare
Updates installation and contributor guides for ReScript 13 alpha. Adds migration notes for #399 and a release guide.
Fixes broken API links and adds automated checks for links within the built site. Replaces bundled fonts with system fonts because their source and licenses could not be verified.
Builds on #399, after #397, and completes the documentation requirements for the issues below. npm Trusted Publishing still needs maintainer verification (#385).
Closes #383, closes #387, closes #388, closes #390, closes #391, closes #392, closes #393, closes #394 and closes #395. Refs #385.