Repository navigation
feat(dialog): add opt-in durable signaling checkpoints - #244
Open
FedorKiselev76 wants to merge 10 commits into
Open
FedorKiselev76 wants to merge 10 commits into
FedorKiselev76 wants to merge 10 commits into
Conversation
Contributor
|
Review: the checkpoint design is sound, opt-in, and default behavior is unchanged. Notes for the rebase:
|
Add a public constructor for non-exhaustive lifecycle records so applications can reconstruct persisted history. Keep restore-time history validation unchanged. Exercise the API from an external integration test across two restores, including absent timestamps and invalid history. Verify the constructor documentation and Embassy build.
Make DialogSnapshot non-exhaustive and require explicit state, CSeq counters and recovery metadata through its public builder. Preserve optional stored values and validate confirmed lifecycle history without discarding pending work. Document the proposed 0.9.0 release gate, legacy storage migration and changed restore behavior. Exercise downstream reconstruction and snapshot admission around the upstream re-INVITE handlers.
Verify that incoming re-INVITE responses wait for storage and that ACK completion produces a quiescent checkpoint. Exercise successful and failed commits before a deferred outgoing ACK handler. Clarify that the interop checkpoint switch configures in-process dialog peers, not the standalone proxy and B2BUA applications.
FedorKiselev76
force-pushed
the
codex/dialog-persistence-checkpoints
branch
from
November 6, 2026 10:17
8020bbe to
580189e
Compare
The caller can report CONFIRMED before the proxy forwards ACK. Wait for a SIPp receive marker before requesting hangup, so this scenario tests retransmission of BYE instead of racing it with the initial ACK.
…rsistence-checkpoints
Check persistence before recording and sending a per-fork ACK. Keep the proposed 0.9 migration notes alongside the released changelog.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds opt-in, application-owned persistence checkpoints around dialog signaling. Protected operations wait for a coherent snapshot to be committed before continuing.
Checkpoints cover outgoing requests, authentication retries, successful INVITE responses before ACK, final responses before transmission, local termination intent, signaling completion, and terminal state.
Each dialog uses a serial persistence worker. Storage callbacks run without internal dialog locks. Lifecycle notifications are released only after a covering checkpoint commits.
Storage errors and timeouts prevent subsequent protected operations and are exposed through
persistence_status(). Recovery remains application-owned: a timeout may leave the commit outcome unknown, and the stack does not replay interrupted SIP transactions.Persistence is disabled by default. Existing
DialogStatenotifications remain protocol notifications, independent of durable commit completion.This PR depends on #245 and its proposed 0.9.0 breaking-change plan, pending maintainer approval. It includes the snapshot builder and lifecycle-record constructor. See
MIGRATING-0.9.mdfor migration details.Rebased onto upstream
mainat895d443, preserving the merged re-INVITE controls, negotiation tracking, persistence binding, and signaling-completion checkpoints.Validation:
Run checkpoint interoperability tests with:
RSIPSTACK_INTEROP_CHECKPOINTS=1 bash scripts/interop/run.sh regression
The switch configures in-process dialog-peer fixtures. Standalone proxy/B2BUA applications also run but use their own layers and are not configured by this switch.