Repository navigation
Type main!'s arguments as OsStr in the platform header - #554
Merged
Merged
Conversation
This was referenced Nov 11, 2026
Anton-4
approved these changes
Nov 12, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The platform header spelled out
main!'s argument type as the tag union behindOsStr, whilemain_for_host!passes aList(OsStr)and every example annotatesmain!withList(OsStr). That only type-checks because the compiler currently lets a written-out tag union stand in for a named type with the same tags, and a planned compiler change makes a written-out type mean exactly what it says. This namesOsStrin the header instead, and writesmain_for_host!'s annotation the same way.Nothing changes for apps on current compilers: apps that annotate
main!withList(OsStr), leave it unannotated, or callOsStr.from_rawon each argument all keep compiling. Once the compiler change lands, the arguments are simplyOsStrvalues, so an app that calledOsStr.from_rawon them passes them toOsStrfunctions directly.