Repository navigation
Conversation
[Medium impact] The PR appears safe to merge. Reviews (1) · Last reviewed commit: "fix(inject): return a null sourcemap whe..." · Reviewed by Greptile |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rollup Plugin Name:
injectThis PR contains:
Are tests included?
Breaking Changes?
If yes, then include "BREAKING CHANGES:" in the first commit message body, followed by a description of what is breaking.
List any relevant issue numbers:
None.
Description
When
injectmatches one of its keys in a module but has nothing to inject, it still returns ahiressourcemap for the unchanged code. Rollup keeps that map on the cached module, so watch mode holds one for each of these modules. A 134 KB module that only callsoptions.process(...)gets a map with 131,780 segments.I hit this in a Nuxt 4 dev server. Nitro 2 runs
injectover every inlined dependency, and these maps took about 1.5 GB of heap per rebuild until the server ran out of memory.This PR returns
map: nullwhen nothing is injected, likereplacedoes. The output sourcemap stays byte-identical. The new test fails onmasterand passes here.Repro with Rollup 4.67.5 and plugin 5.0.5, plus a patched control: https://github.com/onmax/repros/tree/repro/rollup-plugin-inject-sourcemap/rollup-plugin-inject-sourcemap (
pnpm install && pnpm verify)