Skip to content

feat(vscode): make manual-publish's vsce leg a no-op for OIDC caller dispatch - W-24756661 - #212

Merged
peternhale merged 1 commit into
mainfrom
ms/W-24756661-vscode-manual-publish-oidc-noop
Nov 16, 2026
Merged

peternhale merged 1 commit into
mainfrom
ms/W-24756661-vscode-manual-publish-oidc-noop

Conversation

@madhur310

@madhur310 madhur310 commented Nov 13, 2026 •

Copy link
Copy Markdown
Contributor

What

vscode-manual-publish.yml's publish job published to the VS Code Marketplace via a PAT, through a job defined in this reusable workflow. The Marketplace's OIDC trust check keys off job_workflow_ref, which for a job in a reusable workflow always points here, never at the caller's own workflow filename — the same OIDC mismatch already fixed for salesforcedx-vscode in #207/#8624.

This mirrors the existing ovsx no-op leg: the vsce leg is now an unconditional no-op too, so the caller dispatches its own OIDC-trusted publish workflow afterward instead (same pattern as the existing publishOpenVSXTrusted.yml dispatch).

apex-language-support is this workflow's only caller (verified via code search — no other consumer), so there's no other caller relying on PAT-based vsce publish through this path, and the extra opt-in input originally considered was dropped as unnecessary.

Verified

The companion PR's dispatch workflow (publishVSCodeMarketplaceTrusted.yml, using the same publish-release-vsix composite action this PR's callers rely on) was run end-to-end against the real VS Code Marketplace using OIDC:

Run 43523373003 — success (against already-released apex-language-server-extension-v0.10.0, dry-run=false, --skip-duplicate safe no-op — no actual publish side effect)

Publishing 'salesforce.apex-language-server-extension v0.10.0'...
Version 0.10.0 is already published. Skipping publish.

⚠️ Breaking change — do not merge standalone

Merging this alone would silently stop the VS Code Marketplace publish in apex-language-support's manual-publish pipeline (the job would report success while doing nothing). This must merge together with (or after) the companion PR in forcedotcom/apex-language-support that adds the OIDC dispatch workflow and wires it in.

Companion PR: forcedotcom/apex-language-support#834

…dispatch - W-24756661

vscode-manual-publish.yml's publish job published vsce via a PAT through
a job defined in this reusable workflow, whose job_workflow_ref can never
match the caller's own workflow filename -- the same OIDC trust mismatch
already solved for ovsx. apex-language-support is this workflow's only
caller, so there's no other consumer relying on PAT-based vsce publish
through this path; make the vsce leg an unconditional no-op mirroring the
existing ovsx leg, and dispatch an OIDC-trusted publish workflow from the
caller instead.

Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
@madhur310

Copy link
Copy Markdown
Contributor Author

Companion PR (ready to merge together): forcedotcom/apex-language-support#834

@madhur310
madhur310 marked this pull request as ready for review November 13, 2026 23:09
@madhur310
madhur310 requested a review from a team as a code owner November 13, 2026 23:09
@peternhale
peternhale merged commit b974ac8 into main Nov 16, 2026
4 checks passed
peternhale added a commit to forcedotcom/apex-language-support that referenced this pull request Nov 16, 2026
…manual-publish - W-24756661 (#834)

* feat(ci): publish VS Code Marketplace via OIDC trusted publishing in manual-publish - W-24756661

publishVSCodeMarketplaceTrusted.yml was a dispatch-only test-registration
workflow for the Marketplace's OIDC trust check. With
salesforcecli/github-workflows#207 merged (the publish-release-vsix OIDC
composite action) and the vscode-manual-publish.yml change in
salesforcecli/github-workflows#212, promote it to the real publish target:
call the composite action directly instead of the old PR-branch reusable
workflow reference, and wire manual-publish.yml to dispatch it on the
version-tag path, mirroring trigger-openvsx-publish.

Depends on salesforcecli/github-workflows#212 merging first -- that PR
makes vscode-manual-publish.yml's vsce leg a no-op, since this workflow
now handles the actual Marketplace publish.

Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>

* build: address sast scan false positive

---------

Co-authored-by: Claude Sonnet 5 <noreply@anthropic.com>
Co-authored-by: peternhale <peternhale@users.noreply.github.com>
Co-authored-by: peternhale <peter.hale@salesforce.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants